[CLEANUP] Split template compiler (#13539)

* [CLEANUP] Split template compiler

* Fix registerPlugin mutability and removes more deprecated transforms

Author: chadhietala

lib/packages.js

@@ -3,28 +3,38 @@ var featuresJson = fs.readFileSync('./features.json', { encoding: 'utf8' });
 var features = JSON.parse(featuresJson).features;
 
 var packages = {
-  'container':                  {trees: null,  requirements: []},
-  'ember-environment':          {trees: null,  requirements: [], skipTests: true},
-  'ember-console':              {trees: null,  requirements: [], skipTests: true},
-  'ember-metal':                {trees: null,  requirements: ['ember-environment'], vendorRequirements: ['backburner']},
-  'ember-debug':                {trees: null,  requirements: ['ember-metal'], testing: true},
-  'ember-runtime':              {trees: null,  vendorRequirements: ['rsvp'], requirements: ['container', 'ember-environment', 'ember-console', 'ember-metal']},
-  'ember-views':                {trees: null,  requirements: ['ember-runtime']},
-  'ember-extension-support':    {trees: null,  requirements: ['ember-application']},
-  'ember-testing':              {trees: null,  requirements: ['ember-application', 'ember-routing'], testing: true},
-  'ember-template-compiler':    {trees: null,  requirements: ['ember-metal', 'ember-environment', 'ember-console'], vendorRequirements: ['htmlbars-runtime'], templateCompilerVendor: ['simple-html-tokenizer', 'morph-range', 'htmlbars-runtime', 'htmlbars-util', 'htmlbars-compiler', 'htmlbars-syntax', 'htmlbars-test-helpers', 'backburner']},
+  'container':                  { trees: null,  requirements: [] },
+  'ember-environment':          { trees: null,  requirements: [], skipTests: true },
+  'ember-console':              { trees: null,  requirements: [], skipTests: true },
+  'ember-metal':                { trees: null,  requirements: ['ember-environment'], vendorRequirements: ['backburner'] },
+  'ember-debug':                { trees: null,  requirements: ['ember-metal'], testing: true },
+  'ember-runtime':              { trees: null,  vendorRequirements: ['rsvp'], requirements: ['container', 'ember-environment', 'ember-console', 'ember-metal'] },
+  'ember-views':                { trees: null,  requirements: ['ember-runtime'] },
+  'ember-extension-support':    { trees: null,  requirements: ['ember-application'] },
+  'ember-testing':              { trees: null,  requirements: ['ember-application', 'ember-routing'], testing: true },
+  'ember-template-compiler': {
+    trees: null,
+    requirements: ['ember-metal', 'ember-environment', 'ember-console', 'ember-htmlbars-template-compiler'],
+    templateCompilerVendor: ['simple-html-tokenizer']
+  },
+  'ember-htmlbars-template-compiler': {
+    trees: null,
+    requirements: [],
+    vendorRequirements: ['htmlbars-runtime'],
+    templateCompilerVendor: ['htmlbars-runtime', 'htmlbars-util', 'htmlbars-compiler', 'htmlbars-syntax', 'htmlbars-test-helpers', 'morph-range', 'backburner']
+  },
   'ember-htmlbars':             {
                                   trees: null,
                                   vendorRequirements: ['dom-helper', 'morph-range', 'morph-attr', 'htmlbars-util', 'htmlbars-runtime'],
                                   requirements: ['ember-routing', 'ember-metal'],
-                                  testingVendorRequirements: [ 'htmlbars-test-helpers'],
+                                  testingVendorRequirements: ['htmlbars-test-helpers'],
                                   hasTemplates: true
                                 },
-  'ember-templates':            {trees: null,  requirements: ['ember-metal', 'ember-environment']},
-  'ember-routing':              {trees: null,  vendorRequirements: ['router', 'route-recognizer'],
-                                               requirements: ['ember-runtime', 'ember-views']},
-  'ember-application':          {trees: null,  vendorRequirements: ['dag-map'], requirements: ['ember-routing']},
-  'ember':                      {trees: null,  requirements: ['ember-application']}
+  'ember-templates':            { trees: null,  requirements: ['ember-metal', 'ember-environment'] },
+  'ember-routing':              { trees: null,  vendorRequirements: ['router', 'route-recognizer'],
+                                               requirements: ['ember-runtime', 'ember-views'] },
+  'ember-application':          { trees: null,  vendorRequirements: ['dag-map'], requirements: ['ember-routing'] },
+  'ember':                      { trees: null,  requirements: ['ember-application'] }
 };
 
 var glimmerStatus = features['ember-glimmer'];
@@ -40,18 +50,24 @@ if (glimmerStatus === null || glimmerStatus === true) {
       'glimmer-util',
       'glimmer-wire-format'
     ],
-    testingVendorRequirements: [],
-    hasTemplates: true
+    testingVendorRequirements: []
+  };
+
+  packages['ember-glimmer-template-compiler'] = {
+    trees: null,
+    requirements: [],
+    templateCompilerVendor: [
+      'glimmer-wire-format',
+      'glimmer-syntax',
+      'glimmer-util',
+      'glimmer-compiler',
+      'glimmer-reference',
+      'glimmer-runtime',
+      'handlebars'
+    ]
   };
 
-  var templateCompiler = packages['ember-template-compiler'];
-  templateCompiler.templateCompilerVendor.push('glimmer-wire-format');
-  templateCompiler.templateCompilerVendor.push('glimmer-syntax');
-  templateCompiler.templateCompilerVendor.push('glimmer-util');
-  templateCompiler.templateCompilerVendor.push('glimmer-compiler');
-  templateCompiler.templateCompilerVendor.push('glimmer-reference');
-  templateCompiler.templateCompilerVendor.push('glimmer-runtime');
-  templateCompiler.templateCompilerVendor.push('handlebars');
+  packages['ember-template-compiler'].requirements.push('ember-glimmer-template-compiler');
 }
 
 module.exports = packages;

package.json

@@ -34,7 +34,7 @@
     "ember-cli-sauce": "^1.4.2",
     "ember-cli-yuidoc": "0.8.3",
     "ember-publisher": "0.0.7",
-    "emberjs-build": "0.9.2",
+    "emberjs-build": "0.10.0",
     "express": "^4.5.0",
     "finalhandler": "^0.4.0",
     "github": "^0.2.3",

packages/ember-application/tests/system/application_test.js

@@ -14,7 +14,7 @@ import EmberObject from 'ember-runtime/system/object';
 import { setSearchDisabled as setNamespaceSearchDisabled } from 'ember-runtime/system/namespace';
 import EmberRoute from 'ember-routing/system/route';
 import jQuery from 'ember-views/system/jquery';
-import compile from 'ember-template-compiler/system/compile';
+import { compile } from 'ember-template-compiler/tests/utils/helpers';
 import { _loaded } from 'ember-runtime/system/lazy_load';
 import { getDebugFunction, setDebugFunction } from 'ember-metal/debug';
 import { setTemplates, set as setTemplate } from 'ember-templates/template_registry';

packages/ember-application/tests/system/dependency_injection/custom_resolver_test.js

@@ -2,7 +2,7 @@ import jQuery from 'ember-views/system/jquery';
 import run from 'ember-metal/run_loop';
 import Application from 'ember-application/system/application';
 import DefaultResolver from 'ember-application/system/resolver';
-import compile from 'ember-template-compiler/system/compile';
+import { compile } from 'ember-template-compiler/tests/utils/helpers';
 
 var application;
 

packages/ember-application/tests/system/logging_test.js

@@ -7,7 +7,7 @@ import View from 'ember-views/views/view';
 import Controller from 'ember-runtime/controllers/controller';
 import Route from 'ember-routing/system/route';
 import RSVP from 'ember-runtime/ext/rsvp';
-import compile from 'ember-template-compiler/system/compile';
+import { compile } from 'ember-template-compiler/tests/utils/helpers';
 
 import 'ember-routing';
 

packages/ember-application/tests/system/visit_test.js

@@ -8,7 +8,7 @@ import Route from 'ember-routing/system/route';
 import Router from 'ember-routing/system/router';
 import View from 'ember-views/views/view';
 import Component from 'ember-htmlbars/component';
-import compile from 'ember-template-compiler/system/compile';
+import { compile } from 'ember-template-compiler/tests/utils/helpers';
 import jQuery from 'ember-views/system/jquery';
 
 let App = null;

packages/ember-glimmer-template-compiler/lib/index.js

@@ -0,0 +1,4 @@
+export { default as compile } from './system/compile';
+export { default as precompile } from './system/precompile';
+export { default as template } from './system/template';
+export { registerPlugin } from './system/compile-options';

packages/ember-glimmer/lib/ember-template-compiler/plugins/transform-action-syntax.js renamed to packages/ember-glimmer-template-compiler/lib/plugins/transform-action-syntax.js

@@ -0,0 +1,44 @@
+import TransformHasBlockSyntax from '../plugins/transform-has-block-syntax';
+import TransformActionSyntax from '../plugins/transform-action-syntax';
+import assign from 'ember-metal/assign';
+
+export const PLUGINS = [
+  TransformHasBlockSyntax,
+  TransformActionSyntax
+];
+
+let USER_PLUGINS = [];
+
+export default function compileOptions(options) {
+  options = options || {};
+  options = assign({}, options);
+  if (!options.plugins) {
+    options.plugins = PLUGINS;
+  } else {
+    let potententialPugins = [...USER_PLUGINS, ...PLUGINS];
+    let pluginsToAdd = potententialPugins.filter((plugin) => {
+      return options.plugins.ast.indexOf(plugin) === -1;
+    });
+    options.plugins.ast = options.plugins.ast.slice().concat(pluginsToAdd);
+  }
+
+  return options;
+}
+
+export function registerPlugin(type, PluginClass) {
+  if (type !== 'ast') {
+    throw new Error(`Attempting to register ${PluginClass} as "${type}" which is not a valid Glimmer plugin type.`);
+  }
+
+  if (USER_PLUGINS.indexOf(PluginClass) === -1) {
+    USER_PLUGINS = [PluginClass, ...USER_PLUGINS];
+  }
+}
+
+export function removePlugin(type, PluginClass) {
+  if (type !== 'ast') {
+    throw new Error(`Attempting to unregister ${PluginClass} as "${type}" which is not a valid Glimmer plugin type.`);
+  }
+
+  USER_PLUGINS = USER_PLUGINS.filter((plugin) => plugin !== PluginClass);
+}