Skip to content

Commit da9443e

Browse files
committed
Merge pull request #13584 from chadhietala/fix-helper-injection-test
[GLIMMER 2] Unskip Helper injections
2 parents cd1fa4a + 1d76fd6 commit da9443e

File tree

1 file changed

+3
-16
lines changed

1 file changed

+3
-16
lines changed

packages/ember/tests/helpers/helper_registration_test.js

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,17 @@
11
import Controller from 'ember-runtime/controllers/controller';
22
import run from 'ember-metal/run_loop';
3-
import helpers from 'ember-htmlbars/helpers';
43
import { compile } from 'ember-template-compiler/tests/utils/helpers';
5-
import Helper, { helper } from 'ember-htmlbars/helper';
4+
import Helper, { helper } from 'ember-templates/helper';
65
import Application from 'ember-application/system/application';
76
import Router from 'ember-routing/system/router';
87
import Service from 'ember-runtime/system/service';
98
import jQuery from 'ember-views/system/jquery';
109
import inject from 'ember-runtime/inject';
11-
import { registerKeyword, resetKeyword } from 'ember-htmlbars/tests/utils';
12-
import viewKeyword from 'ember-htmlbars/keywords/view';
1310
import { setTemplates, set as setTemplate } from 'ember-templates/template_registry';
1411

15-
var App, appInstance, originalViewKeyword;
12+
var App, appInstance;
1613

1714
QUnit.module('Application Lifecycle - Helper Registration', {
18-
setup() {
19-
originalViewKeyword = registerKeyword('view', viewKeyword);
20-
},
2115
teardown() {
2216
run(function() {
2317
if (App) {
@@ -27,8 +21,6 @@ QUnit.module('Application Lifecycle - Helper Registration', {
2721
App = appInstance = null;
2822
setTemplates({});
2923
});
30-
delete helpers['foo-bar-baz-widget'];
31-
resetKeyword('view', originalViewKeyword);
3224
}
3325
});
3426

@@ -69,7 +61,6 @@ QUnit.test('Unbound dashed helpers registered on the container can be late-invok
6961
});
7062

7163
equal(jQuery('#wrapper').text(), 'BORF YES', 'The helper was invoked from the container');
72-
ok(!helpers['x-borf'], 'Container-registered helper doesn\'t wind up on global helpers hash');
7364
});
7465

7566
QUnit.test('Bound helpers registered on the container can be late-invoked', function() {
@@ -86,7 +77,6 @@ QUnit.test('Bound helpers registered on the container can be late-invoked', func
8677
});
8778

8879
equal(jQuery('#wrapper').text(), '-- xela', 'The bound helper was invoked from the container');
89-
ok(!helpers['x-reverse'], 'Container-registered helper doesn\'t wind up on global helpers hash');
9080
});
9181

9282
QUnit.test('Undashed helpers registered on the container can be invoked', function() {
@@ -105,10 +95,7 @@ QUnit.test('Undashed helpers registered on the container can be invoked', functi
10595
equal(jQuery('#wrapper').text(), 'OMG|boo|ya', 'The helper was invoked from the container');
10696
});
10797

108-
import { test } from 'ember-glimmer/tests/utils/skip-if-glimmer';
109-
110-
// needs glimmer Helper
111-
test('Helpers can receive injections', function() {
98+
QUnit.test('Helpers can receive injections', function() {
11299
setTemplate('application', compile('<div id=\'wrapper\'>{{full-name}}</div>'));
113100

114101
var serviceCalled = false;

0 commit comments

Comments
 (0)