Make _renderMode private

Author: rondale-sc

packages/ember-application/lib/system/application-instance.js

@@ -343,12 +343,12 @@ function BootOptions(options = {}) {
   this.isInteractive = environment.hasDOM; // This default is overridable below
 
   /**
-    @property renderMode
+    @property _renderMode
     @type string
     @default false
-    @public
+    @private
   */
-  this.renderMode = options.renderMode;
+  this._renderMode = options._renderMode;
 
   /**
     Run in a full browser environment.
@@ -489,7 +489,7 @@ BootOptions.prototype.toEnvironment = function() {
   // For compatibility with existing code
   env.hasDOM = this.isBrowser;
   env.isInteractive = this.isInteractive;
-  env.renderMode = this.renderMode;
+  env._renderMode = this._renderMode;
   env.options = this;
   return env;
 };

packages/ember-application/tests/system/visit_test.js

@@ -53,7 +53,7 @@ moduleFor('Application - visit()', class extends ApplicationTestCase {
     });
   }
 
-  [`@test renderMode: rehydrate`](assert) {
+  [`@test _renderMode: rehydrate`](assert) {
 
     let initialHTML = `<!--%+block:0%--><!--%+block:1%--><!--%+block:2%--><!--%+block:3%--><!--%+block:4%--><!--%+block:5%--><!--%+block:6%--><div class=\"foo\">Hi, Mom!</div><!--%-block:6%--><!--%-block:5%--><!--%-block:4%--><!--%-block:3%--><!--%-block:2%--><!--%-block:1%--><!--%-block:0%-->`;
 
@@ -64,7 +64,7 @@ moduleFor('Application - visit()', class extends ApplicationTestCase {
     let bootOptions = {
       isBrowser: false,
       rootElement,
-      renderMode: 'rehydrate'
+      _renderMode: 'rehydrate'
     };
 
     ENV._APPLICATION_TEMPLATE_WRAPPER = false;
@@ -75,14 +75,14 @@ moduleFor('Application - visit()', class extends ApplicationTestCase {
     });
   }
 
-  [`@test renderMode: serialize`](assert) {
+  [`@test _renderMode: serialize`](assert) {
     this.addTemplate('index', '<div class="foo">Hi, Mom!</div>');
     let rootElement = document.createElement('div');
 
     let bootOptions = {
       isBrowser: false,
       rootElement,
-      renderMode: 'serialize'
+      _renderMode: 'serialize'
     };
 
     ENV._APPLICATION_TEMPLATE_WRAPPER = false;

packages/ember-glimmer/lib/setup-registry.ts

@@ -33,10 +33,10 @@ export function setupApplicationRegistry(registry: Registry) {
   registry.injection('renderer', 'env', 'service:-glimmer-environment');
 
   registry.register('service:-dom-builder', {
-    create({ bootOptions }: { bootOptions: { renderMode: string } }) {
-      let { renderMode } = bootOptions;
+    create({ bootOptions }: { bootOptions: { _renderMode: string } }) {
+      let { _renderMode } = bootOptions;
 
-      switch(renderMode) {
+      switch(_renderMode) {
         case 'serialize': return serializeBuilder;
         case 'rehydrate': return rehydrationBuilder;
         default: return clientBuilder;