Skip to content

Commit a116b36

Browse files
chadhietalakrisselden
authored andcommitted
[CLEANUP] Begin purging {{view}} keyword in tests (#13561)
1 parent d820fe4 commit a116b36

File tree

9 files changed

+4
-606
lines changed

9 files changed

+4
-606
lines changed

packages/ember-glimmer/tests/integration/components/curly-components-test.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2127,6 +2127,10 @@ moduleFor('Components test: curly components', class extends RenderingTest {
21272127

21282128
this.assertText('updated value - updated value');
21292129

2130+
this.runTask(() => { component.set('bar', undefined); });
2131+
2132+
this.assertText(' - ');
2133+
21302134
this.runTask(() => { this.component.set('localBar', 'initial value'); });
21312135

21322136
this.assertText('initial value - initial value');

packages/ember-views/tests/compat/attrs_proxy_test.js

Lines changed: 0 additions & 108 deletions
This file was deleted.

packages/ember-views/tests/system/event_dispatcher_test.js

Lines changed: 0 additions & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -100,59 +100,6 @@ if (isEnabled('ember-improved-instrumentation')) {
100100
});
101101
}
102102

103-
QUnit.test('should dispatch events to views', function() {
104-
var receivedEvent;
105-
var parentMouseDownCalled = 0;
106-
var childKeyDownCalled = 0;
107-
var parentKeyDownCalled = 0;
108-
109-
var childView = View.extend({
110-
keyDown(evt) {
111-
childKeyDownCalled++;
112-
113-
return false;
114-
}
115-
}).create({
116-
template: compile('<span id="wot">ewot</span>')
117-
});
118-
119-
view = View.extend({
120-
mouseDown(evt) {
121-
parentMouseDownCalled++;
122-
receivedEvent = evt;
123-
},
124-
125-
keyDown(evt) {
126-
parentKeyDownCalled++;
127-
}
128-
}).create({
129-
template: compile('some <span id="awesome">awesome</span> content {{view view.childView}}'),
130-
childView: childView
131-
});
132-
133-
run(function() {
134-
view.appendTo('#qunit-fixture');
135-
});
136-
137-
view.$().trigger('mousedown');
138-
139-
ok(receivedEvent, 'passes event to associated event method');
140-
receivedEvent = null;
141-
parentMouseDownCalled = 0;
142-
143-
view.$('span#awesome').trigger('mousedown');
144-
ok(receivedEvent, 'event bubbles up to nearest View');
145-
equal(parentMouseDownCalled, 1, 'does not trigger the parent handlers twice because of browser bubbling');
146-
receivedEvent = null;
147-
148-
jQuery('#wot').trigger('mousedown');
149-
ok(receivedEvent, 'event bubbles up to nearest View');
150-
151-
jQuery('#wot').trigger('keydown');
152-
equal(childKeyDownCalled, 1, 'calls keyDown on child view');
153-
equal(parentKeyDownCalled, 0, 'does not call keyDown on parent if child handles event');
154-
});
155-
156103
QUnit.test('should not dispatch events to views not inDOM', function() {
157104
var receivedEvent;
158105

packages/ember-views/tests/system/ext_test.js

Lines changed: 0 additions & 48 deletions
This file was deleted.

packages/ember-views/tests/views/view/append_to_test.js

Lines changed: 0 additions & 102 deletions
Original file line numberDiff line numberDiff line change
@@ -98,108 +98,6 @@ QUnit.test('raises an assert when a target does not exist in the DOM', function(
9898
});
9999
});
100100

101-
QUnit.test('append calls willInsertElement and didInsertElement callbacks', function() {
102-
var willInsertElementCalled = false;
103-
var willInsertElementCalledInChild = false;
104-
var didInsertElementCalled = false;
105-
106-
var ViewWithCallback = View.extend({
107-
willInsertElement() {
108-
willInsertElementCalled = true;
109-
},
110-
didInsertElement() {
111-
didInsertElementCalled = true;
112-
},
113-
childView: EmberView.create({
114-
willInsertElement() {
115-
willInsertElementCalledInChild = true;
116-
}
117-
}),
118-
template: compile('{{view view.childView}}')
119-
});
120-
121-
view = ViewWithCallback.create();
122-
123-
run(function() {
124-
view.append();
125-
});
126-
127-
ok(willInsertElementCalled, 'willInsertElement called');
128-
ok(willInsertElementCalledInChild, 'willInsertElement called in child');
129-
ok(didInsertElementCalled, 'didInsertElement called');
130-
});
131-
132-
QUnit.test('a view calls its children\'s willInsertElement and didInsertElement', function() {
133-
var parentView;
134-
var willInsertElementCalled = false;
135-
var didInsertElementCalled = false;
136-
var didInsertElementSawElement = false;
137-
138-
parentView = EmberView.create({
139-
ViewWithCallback: EmberView.extend({
140-
template: compile('<div id="do-i-exist"></div>'),
141-
142-
willInsertElement() {
143-
willInsertElementCalled = true;
144-
},
145-
didInsertElement() {
146-
didInsertElementCalled = true;
147-
didInsertElementSawElement = (this.$('div').length === 1);
148-
}
149-
}),
150-
151-
template: compile('{{#if view.condition}}{{view view.ViewWithCallback}}{{/if}}'),
152-
condition: false
153-
});
154-
155-
run(function() {
156-
parentView.append();
157-
});
158-
run(function() {
159-
parentView.set('condition', true);
160-
});
161-
162-
ok(willInsertElementCalled, 'willInsertElement called');
163-
ok(didInsertElementCalled, 'didInsertElement called');
164-
ok(didInsertElementSawElement, 'didInsertElement saw element');
165-
166-
run(function() {
167-
parentView.destroy();
168-
});
169-
});
170-
171-
QUnit.test('replacing a view should invalidate childView elements', function() {
172-
var elementOnDidInsert;
173-
174-
view = EmberView.create({
175-
show: false,
176-
177-
CustomView: EmberView.extend({
178-
init() {
179-
this._super(...arguments);
180-
// This will be called in preRender
181-
// We want it to cache a null value
182-
// Hopefully it will be invalidated when `show` is toggled
183-
this.get('element');
184-
},
185-
186-
didInsertElement() {
187-
elementOnDidInsert = this.get('element');
188-
}
189-
}),
190-
191-
template: compile('{{#if view.show}}{{view view.CustomView}}{{/if}}')
192-
});
193-
194-
run(function() { view.append(); });
195-
196-
run(function() { view.set('show', true); });
197-
198-
ok(elementOnDidInsert, 'should have an element on insert');
199-
200-
run(function() { view.destroy(); });
201-
});
202-
203101
QUnit.test('trigger rerender of parent and SimpleBoundView', function () {
204102
var view = EmberView.create({
205103
show: true,

packages/ember-views/tests/views/view/nested_view_ordering_test.js

Lines changed: 0 additions & 49 deletions
This file was deleted.

0 commit comments

Comments
 (0)