Deprecate default route store

Author: wagenet

packages/@ember/routing/route.ts

@@ -1501,7 +1501,9 @@ class Route<T = unknown>
       }
     );
 
+    this._disableStoreDeprecation = true;
     const store = get(this, 'store');
+    this._disableStoreDeprecation = false;
     assert('Expected route to have a store with a find method', isStoreLike(store));
 
     return store.find(type, value);
@@ -1831,6 +1833,14 @@ class Route<T = unknown>
     return params;
   }
 
+  /**
+   * Set to true to disable the built-in store deprecation warning.
+   * This helps avoid double calls from the `findModel` hook.
+   *
+   * @private
+   */
+  _disableStoreDeprecation = false;
+
   /**
     Store property provides a hook for data persistence libraries to inject themselves.
 
@@ -1843,10 +1853,23 @@ class Route<T = unknown>
 
     @property store
     @type {Object}
+    @deprecated Manually define your own store, such as with `@service store`
     @private
   */
   @computed
   protected get store() {
+    deprecate(
+      `The default store behavior for routes is deprecated. Please define an ` +
+      `explicit store for ${this.fullRouteName}, such as with \`@service store\`.`,
+      this._disableStoreDeprecation,
+      {
+        id: 'deprecate-defaul-route-store',
+        for: 'ember-source',
+        since: { available: '4.12.0' },
+        until: '6.0.0',
+      }
+    );
+
     const owner = getOwner(this);
     assert('Route is unexpectedly missing an owner', owner);
     let routeName = this.routeName;

packages/@ember/routing/tests/system/route_test.js

@@ -67,6 +67,31 @@ moduleFor(
       runDestroy(owner);
     }
 
+    ['@test default store is deprecated']() {
+      let owner = buildOwner();
+      setOwner(route, owner);
+
+      expectDeprecation(() => route.store, /The default store behavior for routes is deprecated./);
+
+      runDestroy(owner);
+    }
+
+    ['@test default store can be overridden'](assert) {
+      runDestroy(route);
+
+      let calledFind = false;
+      route = EmberRoute.extend({
+        store: {
+          find() {
+            calledFind = true;
+          },
+        },
+      }).create();
+
+      route.store.find();
+      assert.true(calledFind, 'store.find was called');
+    }
+
     ["@test assert if 'store.find' method is not found"]() {
       runDestroy(route);