Skip to content

Commit 39b606f

Browse files
authored
Merge pull request #12964 from Charizard/fix-stack-trace-in-firefox
[BUGFIX beta] Fix Error object's stacktrace inconsistency across browsers
2 parents ece9045 + 6a97907 commit 39b606f

File tree

1 file changed

+13
-1
lines changed

1 file changed

+13
-1
lines changed

packages/ember-metal/lib/error_handler.js

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,18 @@
11
import Logger from 'ember-console';
22
import { isTesting } from './testing';
33

4+
// To maintain stacktrace consistency across browsers
5+
let getStack = function(error) {
6+
var stack = error.stack;
7+
var message = error.message;
8+
9+
if (stack.indexOf(message) === -1) {
10+
stack = message + '\n' + stack;
11+
}
12+
13+
return stack;
14+
};
15+
416
let onerror;
517
// Ember.onerror getter
618
export function getOnerror() {
@@ -33,6 +45,6 @@ function defaultDispatch(error) {
3345
if (onerror) {
3446
onerror(error);
3547
} else {
36-
Logger.error(error.stack);
48+
Logger.error(getStack(error));
3749
}
3850
}

0 commit comments

Comments
 (0)