-
-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some specific documentation for uploading files #340
Conversation
I'm assuming these test failures have nothing to do with this doc change. |
The API docs are automatically generated, so you would have to change this in the JS docs, not in the API docs directly. |
d80d94b
to
11c801c
Compare
Whoops. Thanks @Turbo87. I fixed that, it doesn't like like docs get built in Travis so I assume I was supposed to commit the change to I had to add |
11c801c
to
603f639
Compare
* 'input.fileUpload', | ||
* 'change', | ||
* [new Blob(['Ember Rules!'])] | ||
* ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a minor indentation issue, this bracket should be moved one char left
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ro0gr. Fixed.
3dc66fe
to
f77ad33
Compare
f77ad33
to
829f4fb
Compare
Uploading files with an event is a specific code path and the task can be tough to figure out without an example.
829f4fb
to
a5a3940
Compare
Yes! Absolutely! |
Thank you! |
Uploading files with an event is a specific code path and the task can
be tough to figure out without an example.
I couldn't think of a better way to document this, but it seemed necessary to me. I've been using a construct like:
So when converting from jQuery helpers to this addon it was difficult to see how to make file uploads work. Turns out some really nice work is done in
fire-event.js
- just needed to be documented.