Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New setupRenderingTest seems to recreate the #ember-testing-container for every test #228

Closed
cibernox opened this issue Oct 19, 2017 · 3 comments · Fixed by #229
Closed

New setupRenderingTest seems to recreate the #ember-testing-container for every test #228

cibernox opened this issue Oct 19, 2017 · 3 comments · Fixed by #229
Labels
bug

Comments

@cibernox
Copy link
Contributor

Run the tests of an app with several tests. P.e. this branch of ember-basic-dropdown: cibernox/ember-basic-dropdown#349

Check the dom after the suite has finished:
screen shot 2017-10-19 at 01 01 32
@rwjblue
Copy link
Member

rwjblue commented Oct 19, 2017

Thank you for reporting! I'm fairly certain that I have made a silly mistake in #226. I'll try to dig in to confirm and fix today...

@rwjblue rwjblue mentioned this issue Oct 20, 2017
Merged
@rwjblue
Copy link
Member

rwjblue commented Oct 20, 2017

Should be fixed by #229. I'll land and release once someone has had a chance to do a sanity check review...

@Turbo87 Turbo87 added the bug label Oct 20, 2017
@cibernox
Copy link
Contributor Author

I can confirm that it is fixed now 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure ember-testing-container is reset properly. rwjblue/ember-test-helpers
3 participants
@rwjblue @Turbo87 @cibernox