Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose element in component integration tests #184

Closed
Turbo87 opened this issue Nov 22, 2016 · 4 comments
Closed

Expose element in component integration tests #184

Turbo87 opened this issue Nov 22, 2016 · 4 comments

Comments

@Turbo87
Copy link
Member

Turbo87 commented Nov 22, 2016

see emberjs/ember.js#14630

/cc @locks @rwjblue

@Turbo87
Copy link
Member Author

Turbo87 commented Nov 22, 2016

Note that this is already exposed as the private _element property (see #172), but should be renamed to element to make it public API.

@les2
Copy link

les2 commented Nov 29, 2016

@Turbo87 would it be necessary (or possible) to create a "deprecating alias" for the old property / maintain backwards compatibility?

my thoughts are that it's not required to maintain back compat because it is private.

but would any important downstream users be broken by renaming this property?

@rwjblue
Copy link
Member

rwjblue commented Nov 29, 2016

I'd prefer to preserve compat if possible. Seems like we can use Object.defineProperty getters or simply save the same element to this.element and this._element...

@rwjblue
Copy link
Member

rwjblue commented Oct 16, 2017

Closed by #220.

@rwjblue rwjblue closed this as completed Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants
@rwjblue @Turbo87 @les2 and others