Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor version 0.5.24 -> 0.5.25 broke my tests #159

Closed
leepfrog opened this issue Jun 7, 2016 · 5 comments
Closed

Minor version 0.5.24 -> 0.5.25 broke my tests #159

leepfrog opened this issue Jun 7, 2016 · 5 comments

Comments

@leepfrog
Copy link

leepfrog commented Jun 7, 2016

Not sure what the root cause is yet -- beginning to diagnose now. Reporting in case others come across the same issue.

@leepfrog
Copy link
Author

leepfrog commented Jun 7, 2016

Also, should be noted that ember-qunit@0.4.20 does not hard-lock the version, so this made tests magically fail on travis (since we do not cache dependencies)

@leepfrog
Copy link
Author

leepfrog commented Jun 7, 2016

Looks like the new version returns this dom:

<div id='"ember-testing" class="ember-application">
  <div id="ember266" class="ember-view">
    <div> ....(my component).... </div>
  </div>
</div>

Old version returned this dom:

  <div id="ember266" class="ember-view">
    <div> ....(my component).... </div>
  </div>

Tests fail because we were using this.$().children() to get the child of the test container (aka component). I assume this isn't expected / the correct practice to follow?

@rwjblue
Copy link
Member

rwjblue commented Jun 7, 2016

@leepfrog - Sorry about the breakage here. Looking now...

@rwjblue
Copy link
Member

rwjblue commented Jun 7, 2016

Sorry for the issues, #160 should have fixed that regression (and added a test to help ensure we don't regress this again).

ember-test-helpers@0.5.26 is released...

@leepfrog
Copy link
Author

leepfrog commented Jun 7, 2016

Thanks for the fast followup @rwjblue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants