Skip to content

Commit acdd479

Browse files
author
Robert Jackson
committed
Drop element importable helper for now.
Might bring it back later in a different incarnation, but removing for now.
1 parent f201c1e commit acdd479

File tree

3 files changed

+2
-17
lines changed

3 files changed

+2
-17
lines changed

addon-test-support/index.js

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,7 @@ export { default as TestModuleForModel } from './legacy-0-6-x/test-module-for-mo
77
export { setResolver } from './resolver';
88
export { default as setupContext, getContext, setContext, unsetContext } from './setup-context';
99
export { default as teardownContext } from './teardown-context';
10-
export {
11-
default as setupRenderingContext,
12-
render,
13-
clearRender,
14-
element,
15-
} from './setup-rendering-context';
10+
export { default as setupRenderingContext, render, clearRender } from './setup-rendering-context';
1611
export { default as teardownRenderingContext } from './teardown-rendering-context';
1712

1813
import Ember from 'ember';

addon-test-support/setup-rendering-context.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,6 @@ export function clearRender() {
2929
return context.clearRender();
3030
}
3131

32-
export let element = undefined;
33-
3432
/*
3533
* Responsible for:
3634
*
@@ -78,7 +76,7 @@ export default function(context) {
7876
outlets: {},
7977
};
8078

81-
let hasRendered;
79+
let element, hasRendered;
8280
let templateId = 0;
8381

8482
if (hasOutletTemplate) {

tests/unit/setup-rendering-context-test.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import {
99
teardownRenderingContext,
1010
render,
1111
clearRender,
12-
element,
1312
} from 'ember-test-helpers';
1413
import hasEmberVersion from 'ember-test-helpers/has-ember-version';
1514
import hasjQuery from '../helpers/has-jquery';
@@ -125,13 +124,6 @@ module('setupRenderingContext', function(hooks) {
125124
assert.equal(this.element.textContent, 'yippie!!');
126125
});
127126

128-
test('imported `element` can be used instead of this.element', async function(assert) {
129-
await this.render(hbs`yippie!!`);
130-
131-
assert.equal(element.textContent, 'yippie!!');
132-
assert.equal(element, this.element);
133-
});
134-
135127
test('imported clearRender can be used instead of this.clearRender', async function(assert) {
136128
let testingRootElement = document.getElementById('ember-testing');
137129

0 commit comments

Comments
 (0)