Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing htmlSafe, and isHtmlSafe Redux #297

Open
jherdman opened this issue Nov 16, 2021 · 3 comments
Open

Missing htmlSafe, and isHtmlSafe Redux #297

jherdman opened this issue Nov 16, 2021 · 3 comments

Comments

@jherdman
Copy link

This is not entirely a duplicate of #235 per se, but possibly related.

I had a production app break recently with a deprecated import { htmlSafe } from '@ember/string' usage. Though this import is deprecated, it's not slated for removal until Ember v4. We tracked the problem down to ember-data v3.24 using @ember/string v1 which is being used in prod instead of Ember Source's.

Is it possible to add these missing functions with a deprecation warning and backport?

@jeradg
Copy link

jeradg commented Nov 18, 2021

Here's a minimal reproducible example of the bug mentioned by @jherdman.

jeradg/ember-prod-test-spike@1a24746

@ef4
Copy link
Contributor

ef4 commented Mar 8, 2022

#235 (comment)

@kategengler
Copy link
Member

I added versions of these methods that error with explanation in #367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants