Add note on testInDebug
#4240
Merged
Add note on testInDebug
#4240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ## Writing Tests | ||
|
|
||
| * We do write tests for our warns and assertion messages. You may use the `assert.expectAssertion()` and `assert.expectWarning()` helpers for this. Note: Our Travis tests that will run on your PR run in the `production` envrionment, where warnings and assertions are stripped. If you're writing a test for these, you should use `testInDebug` helper rather than `test` to define your test. | ||
|
|
There was a problem hiding this comment.
Typo: envrionment -> environment
I think it would be good to add a small sample which clarifies where to import that testInDebug helper from and how it is used instead of test...
There was a problem hiding this comment.
I'll link to an existing test using it
There was a problem hiding this comment.
That's good also! Just in case you haven't thought already about that: I would suggest a link using the specific commit, and not master, so the link stays resilient to changes. You can achieve that by pressing y to get the canonical form: https://help.github.com/articles/getting-permanent-links-to-files/.
Addresses point 4 in Issue emberjs#4238
|
Thanks @courajs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses point 4 in Issue #4238