Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PerformanceCheck CI Improvements #6730

Open
1 of 8 tasks
runspired opened this issue Nov 12, 2019 · 0 comments
Open
1 of 8 tasks

PerformanceCheck CI Improvements #6730

runspired opened this issue Nov 12, 2019 · 0 comments

Comments

@runspired
Copy link
Contributor

runspired commented Nov 12, 2019

  • use compare instead of HARRemix
  • autogen HAR
  • use current app always, build assets for other commit and install them as necessary
    • or if we automate publishing canary always test against latest canary
  • fix comment post script
  • use a secret token with comment permissions so PR's from forks can comment
    • use a check on master with master token to delete comments to avoid giving perms to forks?
      • use check on master only?
  • format comment and CI output into easily digestible report (produce our own report instead of using compare:analyze)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

1 participant