Catch exceptions on rustc build errors #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When rustc returned a nonzero code, an unhandled exception was raised. This catches the exception and prints a human and tool-friendly report.
emberian
added a commit
that referenced
this pull request
Apr 14, 2014
Catch exceptions on rustc build errors
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Corey, one more change if you don't mind.
When rustc fails to build a crate, cargo-lite spits out a traceback. So this catches the exception and prints out a nicer error message. Also, some tools (emacs, VS and Eclipse I think, and I'm sure vim can do it, too) are able to parse the gcc, clang, rustc, etc. error reports and do things like jumping to the offending line.
So I made the output compatible with that (the
error:prefix before stdout was breaking it).