Merge this just before merging octane branch - important infra updates
#1195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jenweber - Can we refactor this so that we can land the content changes independently of the infrastructure changes? Specifically I'd like to get ember-learn/super-rentals-tutorial#112 and 1a87b81 landed and into the guides preview site so we can do reviews before going live "for real". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should only be merged just before we merge the octane branch to master. Otherwise it will mess with SEO and provide a broken experience on the octane-guides-preview site.
Per checklist in the Quest issue #669, there were some changes to undo before we ship:
Make sure that the content in ember-learn/super-rentals-tutorial#112 gets merged as well!