Skip to content

Modern favicons #1019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 24, 2023
Merged

Modern favicons #1019

merged 4 commits into from
May 24, 2023

Conversation

kaermorchen
Copy link
Contributor

This PR adds modern favicons. It contains some icons:

  1. icon.svg for modern browsers, the dark mode included
  2. favicon.ico contains two 32px and 16px images for legacy browsers
  3. apple-touch-icon.png for Apple devices
  4. Also icon-512, icon-192 and manifest.webmanifest for others

I have removed the old favicon.png file to reduce confusions

@netlify
Copy link

netlify bot commented May 12, 2023

Deploy Preview for ember-website ready!

Name Link
🔨 Latest commit 15ab307
🔍 Latest deploy log https://app.netlify.com/sites/ember-website/deploys/645de64821bb68000746c23b
😎 Deploy Preview https://deploy-preview-1019--ember-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@MinThaMie MinThaMie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome :) thanks for the work!

Copy link
Contributor

@MinThaMie MinThaMie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wifelette can you check if this is the color we want? It's not the same as the old one and also not the same icon as mentioned on the brading page.

@kaermorchen thanks for this, where did you get the logo from :)

@kaermorchen
Copy link
Contributor Author

@kaermorchen thanks for this, where did you get the logo from :)

The logo is taken from this directory, don't remember which one.

The color is taken from this pdf, page 13.

I can change the colors, tell me to which one.

@wifelette
Copy link
Member

This is lovely, thank you! That is indeed the correct page of the correct version of the guide. I can't recall if we updated the assets at that time though, or just the guide.

TL;DR the orange color should be #DB3122, which is the web accessible version of the Ember orange. If it is, we're good to go!

If it isn't, you can either change the color and remake the png, or let me know that I need to get new assets and I shall :)

Thanks @kaermorchen for doing the work, @MinThaMie for being ever-vigilant, and @MelSumner for making sure we updated our Style Guide with the correct colors!

@kaermorchen
Copy link
Contributor Author

kaermorchen commented May 22, 2023

The orange color in the svg file and the images is exactly #DB3122.

Copy link
Contributor

@MinThaMie MinThaMie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for the work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants