-
-
Notifications
You must be signed in to change notification settings - Fork 191
Modern favicons #1019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modern favicons #1019
Conversation
✅ Deploy Preview for ember-website ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome :) thanks for the work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wifelette can you check if this is the color we want? It's not the same as the old one and also not the same icon as mentioned on the brading page.
@kaermorchen thanks for this, where did you get the logo from :)
The logo is taken from this directory, don't remember which one. The color is taken from this pdf, page 13. I can change the colors, tell me to which one. |
This is lovely, thank you! That is indeed the correct page of the correct version of the guide. I can't recall if we updated the assets at that time though, or just the guide. TL;DR the orange color should be If it isn't, you can either change the color and remake the png, or let me know that I need to get new assets and I shall :) Thanks @kaermorchen for doing the work, @MinThaMie for being ever-vigilant, and @MelSumner for making sure we updated our Style Guide with the correct colors! |
The orange color in the svg file and the images is exactly #DB3122. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks for the work!
This PR adds modern favicons. It contains some icons:
icon.svg
for modern browsers, the dark mode includedfavicon.ico
contains two 32px and 16px images for legacy browsersapple-touch-icon.png
for Apple devicesicon-512
,icon-192
andmanifest.webmanifest
for othersI have removed the old favicon.png file to reduce confusions