Merge pull request #129 from ember-learn/update-eslint

Update eslint and prettier

Author: mansona

.eslintrc.js

@@ -3,22 +3,23 @@ module.exports = {
 		es6: true,
 		node: true,
 	},
-	extends: 'eslint:recommended',
+	extends: ['eslint:recommended', 'plugin:prettier/recommended', 'plugin:n/recommended'],
 	parserOptions: {
-		ecmaVersion: 2018,
+		ecmaVersion: 2020,
 		sourceType: 'module',
 	},
 	rules: {
-		indent: ['error', 'tab'],
-		'linebreak-style': ['error', 'unix'],
-		quotes: ['error', 'single'],
-		semi: ['error', 'never'],
-		'no-console': ['off'],
-	},
-	globals: {
-		describe: true,
-		it: true,
-		beforeEach: true,
-		afterEach: true,
+		'n/no-process-exit': 0,
 	},
+	overrides: [
+		{
+			files: 'test/**/*',
+			env: {
+				mocha: true,
+			},
+			rules: {
+				'n/no-unpublished-import': 0,
+			},
+		},
+	],
 }

.prettierrc

@@ -2,6 +2,5 @@
 	"singleQuote": true,
 	"semi": false,
 	"printWidth": 100,
-	"useTabs": true,
-	"trailingComma": "es5"
+  "arrowParens": "avoid"
 }

generate-local.js

@@ -4,7 +4,6 @@ import execa from 'execa'
 import { copyFileSync, ensureFileSync, existsSync, removeSync } from 'fs-extra'
 import minimist from 'minimist'
 import path from 'path'
-import 'hard-rejection/register'
 
 const docsPath = '../ember-api-docs-data'
 
@@ -17,7 +16,7 @@ const exit = function exit() {
 	process.exit(1)
 }
 
-async function  runCmd (cmd, path, args = []) {
+async function runCmd(cmd, path, args = []) {
 	console.log(chalk.underline(`Running '${chalk.green(cmd)}' in ${path}`))
 	const executedCmd = await execa(cmd, args, { cwd: path, shell: true, stdio: 'inherit' })
 
@@ -30,11 +29,11 @@ async function  runCmd (cmd, path, args = []) {
 	console.log(executedCmd.stdout + '\n')
 }
 
-(async () => {
+;(async () => {
 	if (!project || !version) {
 		exit(
 			chalk.red('Both project and version args are required.\n'),
-			chalk.yellow(' e.g., yarn gen --project ember --version 3.10.1')
+			chalk.yellow(' e.g., yarn gen --project ember --version 3.10.1'),
 		)
 	}
 
@@ -66,13 +65,15 @@ async function  runCmd (cmd, path, args = []) {
 			await runCmd('corepack', projDirPath, ['pnpm', 'install'])
 		}
 
-
 		if (install) {
 			await runCmd(project === 'ember' ? 'yarn' : 'pnpm install', projDirPath)
 			console.log('\n\n')
 		}
 
-		await runCmd(project === 'ember' ? 'volta run yarn docs' : 'corepack pnpm run build:docs', projDirPath)
+		await runCmd(
+			project === 'ember' ? 'volta run yarn docs' : 'corepack pnpm run build:docs',
+			projDirPath,
+		)
 
 		let destination = `${docsPath}/s3-docs/v${version}/${project}-docs.json`
 		ensureFileSync(destination)
@@ -82,7 +83,7 @@ async function  runCmd (cmd, path, args = []) {
 
 		const yuiDocFile = path.join(
 			projDirPath,
-			project === 'ember' ? 'docs/data.json' : 'packages/-ember-data/dist/docs/data.json'
+			project === 'ember' ? 'docs/data.json' : 'packages/-ember-data/dist/docs/data.json',
 		)
 		copyFileSync(yuiDocFile, projYuiDocFile)
 	}
@@ -102,6 +103,6 @@ async function  runCmd (cmd, path, args = []) {
 		project,
 		'--version',
 		version,
-		'--no-sync'
+		'--no-sync',
 	]).stdout.pipe(process.stdout)
 })()

index.js

@@ -1,6 +1,5 @@
 // eslint-disable-next-line
 require = require('esm')(module /*, options*/)
-require('hard-rejection')()
 
 const argv = require('minimist')(process.argv.slice(2))
 

lib/add-since-tags.js

@@ -50,7 +50,7 @@ function sortVersionIndex(versionIndex) {
 	let keys = Object.keys(versionIndex)
 
 	keys.forEach(key =>
-		Object.keys(versionIndex[key]).forEach(item => versionIndex[key][item].sort())
+		Object.keys(versionIndex[key]).forEach(item => versionIndex[key][item].sort()),
 	)
 }
 
@@ -63,5 +63,5 @@ const createMethodEntry = (versionIndex, method, itemType, version) => {
 const classItemsWithItemType = versions =>
 	versions.reduce(
 		(memo, { data }) => memo.concat(data.classitems.filter(({ itemtype }) => itemtype)),
-		[]
+		[],
 	)

lib/create-classes.js

@@ -1,4 +1,4 @@
-import saveDoc from './save-document'
+import saveDoc from './save-document.js'
 
 export default async function (document, projectName, projectVersion) {
 	let things = document.data

lib/create-project-versions.js

@@ -1,6 +1,7 @@
+// eslint-disable-next-line n/no-missing-import
 import tojsonapi from 'yuidoc-to-jsonapi/lib/converter'
-import saveDoc from './save-document'
-import updateIDs from './update-with-versions-and-project'
+import saveDoc from './save-document.js'
+import updateIDs from './update-with-versions-and-project.js'
 
 export default async function createProjectVersions(versions, projectName) {
 	const results = []

lib/fix-borked-yuidoc-files.js

@@ -1,8 +1,8 @@
 import fs from 'fs-extra'
 import semverCompare from 'semver-compare'
-import { normalizeYuiDocClassItem } from './yuidoc-fixer/normalize-yui-doc-class-item'
-import { yuiDocClassItemKeys } from './yuidoc-fixer/yui-doc-class-item-keys'
-import { normalizeYuiDocClass } from './yuidoc-fixer/normalize-yui-doc-class'
+import { normalizeYuiDocClassItem } from './yuidoc-fixer/normalize-yui-doc-class-item.js'
+import { yuiDocClassItemKeys } from './yuidoc-fixer/yui-doc-class-item-keys.js'
+import { normalizeYuiDocClass } from './yuidoc-fixer/normalize-yui-doc-class.js'
 
 /**
  * In ember 3.10 and above we introduced decorators.

lib/get-latest-patch-versions.js

@@ -5,7 +5,7 @@ import semverUtils from 'semver-utils'
 export function getLatestPatchVersions(versions) {
 	let groupedVersions = groupBy(
 		versions.sort(semverCompare).map(semverUtils.parse),
-		v => `${v.major}.${v.minor}`
+		v => `${v.major}.${v.minor}`,
 	)
 	return Object.values(groupedVersions).map(verGroup => verGroup.pop().version)
 }

lib/get-version-index.js

@@ -1,4 +1,4 @@
-import { byType } from './filter-jsonapi-doc'
+import { byType } from './filter-jsonapi-doc.js'
 
 export default function getVersionIndex(doc, projectName) {
 	return {