Skip to content

Expose compileMarkdown as public API #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 12, 2019
Merged

Conversation

samselikoff
Copy link
Contributor

@samselikoff
Copy link
Contributor Author

Use case here was rendering Markdown content in Mirage's blog (example).

AddonDocs sites should be able to do this using the same Markdown renderer used by AddonDocs' own components.

The implementation here moves the compile-markdown function into a new addon-docs-shared subdirectory, which is acting like its own npm package. This is so that it can be require()'d by node scripts, and also Auto Import'd by Ember app code. This is to support run-time use cases (like Mirage's blog).

Test included in the dummy addon.

For more history see this Auto Import issue.

@samselikoff samselikoff force-pushed the export-compile-markdown branch from 0471cf0 to 51af297 Compare February 12, 2019 17:32
@samselikoff samselikoff force-pushed the export-compile-markdown branch from 51af297 to 78714b6 Compare February 12, 2019 17:58
@samselikoff samselikoff merged commit ac5147b into master Feb 12, 2019
@samselikoff samselikoff deleted the export-compile-markdown branch February 12, 2019 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the markdown renderer w/syntax highlighting a public function
1 participant