Skip to content

Commit 2be830f

Browse files
Bump some deps, fix some lint (#887)
* Bump some deps, fix some lint * Update snippets.hbs
1 parent 73b94b7 commit 2be830f

File tree

7 files changed

+1731
-2021
lines changed

7 files changed

+1731
-2021
lines changed

.template-lintrc.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@ module.exports = {
66
// TODO: fix these and enable octane
77
'no-action': false,
88
'no-curly-component-invocation': false,
9-
'no-duplicate-id': false,
10-
'no-extra-mut-helper-argument': false,
119
'no-implicit-this': false,
1210
'no-inline-styles': false,
1311
'no-invalid-interactive': false,

addon/components/docs-header/template.hbs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@
2121
link=(component "docs-header/link")
2222
)}}
2323

24-
<DocsHeader::SearchBox @query={{this.query}} @on-input={{action (mut this.query)}} />
24+
<DocsHeader::SearchBox @query={{this.query}} @on-input={{set this "query"}} />
2525

26-
<DocsHeader::Link @on-click={{action (toggle "isShowingVersionSelector" this)}}>
26+
<DocsHeader::Link @on-click={{toggle "isShowingVersionSelector" this}}>
2727
<span data-test-id="current-version" data-version-selector class="docs-flex docs-items-center">
2828

2929
{{#if (eq this.currentVersion.key this.latestVersionName)}}
@@ -59,5 +59,5 @@
5959
{{/if}}
6060

6161
{{#if this.isShowingVersionSelector}}
62-
<DocsHeader::VersionSelector @on-close={{action (mut this.isShowingVersionSelector false)}} />
62+
<DocsHeader::VersionSelector @on-close={{set this "isShowingVersionSelector" false}} />
6363
{{/if}}

addon/components/docs-viewer/template.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<div class="md:docs-flex docs-w-full">
22
{{yield (hash
33
nav=(component "docs-viewer/x-nav")
4-
main=(component "docs-viewer/x-main" onReindex=(action (mut this.pageIndex)))
4+
main=(component "docs-viewer/x-main" onReindex=(set this "pageIndex"))
55
)}}
66

77
<DocsViewer::XCurrentPageIndex @pageIndex={{this.pageIndex}} />

addon/components/docs-viewer/x-nav/template.hbs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
{{#if @media.isMobile}}
22
<div class="docs-text-right docs-px-4 md:docs-px-6 docs-mt-4">
3-
<button {{action (toggle "isShowingMenu" this)}}
3+
<button {{on "click" (toggle "isShowingMenu" this)}}
44
class="docs-text-grey-darkest docs-py-2 docs-text-xs docs-rounded docs-uppercase docs-font-medium">
55
☰ Menu
66
</button>
77
</div>
88
{{/if}}
99

1010
<div class="AddonDocs-DocsViewer-Nav docs-bg-grey-lightest docs-border-r docs-flex-no-shrink">
11-
<nav onclick={{action (mut this.isShowingMenu) false}}
11+
<nav onclick={{set this "isShowingMenu" false}}
1212
class="
1313
docs-absolute docs-right-0 md:docs-relative docs-shadow-lg md:docs-shadow-none docs-mr-2 md:docs-mr-0 md:docs-pl-2
1414
docs-max-w-xs docs-w-90% md:docs-w-72 docs-z-10 docs-transition md:docs-sticky md:docs-top-0
@@ -19,7 +19,7 @@
1919
<div class="docs-pt-px docs-mb-8 docs-px-3 md:docs-px-4 md:docs-max-h-screen md:docs-overflow-y-scroll">
2020
{{#if @media.isMobile}}
2121
<div class="docs-text-right">
22-
<button onclick={{action (mut thisisShowingMenu) false}}
22+
<button onclick={{set this "isShowingMenu" false}}
2323
class="docs-text-grey-darkest docs-opacity-50 hover:docs-opacity-100 docs-text-large-5 docs-py-2 docs-no-underline">
2424
&times;
2525
</button>

package.json

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
"broccoli-caching-writer": "^3.0.3",
4141
"broccoli-debug": "^0.6.5",
4242
"broccoli-filter": "^1.3.0",
43-
"broccoli-funnel": "^3.0.6",
43+
"broccoli-funnel": "^3.0.8",
4444
"broccoli-merge-trees": "^4.2.0",
4545
"broccoli-persistent-filter": "^3.1.0",
4646
"broccoli-plugin": "1.5.1 - 5",
@@ -53,7 +53,7 @@
5353
"ember-cli-babel": "^7.26.3",
5454
"ember-cli-clipboard": "^0.15.0",
5555
"ember-cli-htmlbars": "^5.7.1",
56-
"ember-cli-postcss": "^7.0.0",
56+
"ember-cli-postcss": "^7.0.2",
5757
"ember-cli-string-helpers": "^6.1.0",
5858
"ember-cli-string-utils": "^1.1.0",
5959
"ember-cli-version-checker": "^5.1.0",
@@ -70,6 +70,7 @@
7070
"ember-responsive": "^4.0.0",
7171
"ember-router-generator": "^2.0.0",
7272
"ember-router-scroll": "^4.0.2",
73+
"ember-set-helper": "^2.0.1",
7374
"ember-svg-jar": "^2.2.3",
7475
"ember-tether": "^2.0.0",
7576
"ember-truth-helpers": "^3.0.0",
@@ -89,7 +90,7 @@
8990
"marked": "^0.8.2",
9091
"pad-start": "^1.0.2",
9192
"parse-git-config": "^3.0.0",
92-
"postcss": "^8.2.1",
93+
"postcss": "^8.3.5",
9394
"postcss-import": "^14.0.0",
9495
"postcss-nested": "^5.0.3",
9596
"postcss-scss": "^4.0.0",
@@ -103,7 +104,7 @@
103104
},
104105
"devDependencies": {
105106
"@ember/optional-features": "^2.0.0",
106-
"@ember/test-helpers": "^2.2.5",
107+
"@ember/test-helpers": "^2.2.8",
107108
"@embroider/test-setup": "^0.42.0",
108109
"@fullhuman/postcss-purgecss": "^3.0.0",
109110
"@glimmer/component": "^1.0.4",
@@ -135,12 +136,12 @@
135136
"ember-resolver": "^8.0.2",
136137
"ember-source": "~3.27.5",
137138
"ember-source-channel-url": "^3.0.0",
138-
"ember-template-lint": "^3.2.0",
139+
"ember-template-lint": "^3.5.0",
139140
"ember-test-selectors": "^5.0.0",
140141
"ember-try": "^1.4.0",
141142
"eslint": "^7.23.0",
142143
"eslint-config-prettier": "^8.1.0",
143-
"eslint-plugin-ember": "^10.3.0",
144+
"eslint-plugin-ember": "^10.5.0",
144145
"eslint-plugin-node": "^11.1.0",
145146
"eslint-plugin-prettier": "^3.3.1",
146147
"loader.js": "^4.7.0",

test-apps/new-addon/tests/dummy/app/templates/snippets.hbs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
{{/docs-snippet}}
1111

1212
<DocsSnippet @name="your-angle-bracket-snippet-name.hbs">
13+
{{!-- template-lint-disable no-duplicate-id --}}
1314
<div id="foo">
1415
{{#my-awesome-thing
1516
some=true

0 commit comments

Comments
 (0)