Merge pull request #871 from ember-learn/852-fix-lint-errors-from-alex-part-4

ijlee2 · web-flow · commit d4f0ca08247b · 2020-12-24T10:34:37.000-06:00
Fixed lint errors from alex (Part 4)
diff --git a/.alexrc b/.alexrc
@@ -1,15 +1,7 @@
 {
   "allow": [
     "he-she",
-    "her-him",
-    "special",
-    "steward-stewardess",
-    "sucks",
-    "trap",
-    "waiters-waitresses",
-    "white",
-    "whites",
-    "whitespace"
+    "her-him"
   ],
   "profanitySureness": 1
 }
diff --git a/content/accessibility-working-group-update.md b/content/accessibility-working-group-update.md
@@ -28,8 +28,7 @@ There were five items listed in [Issue 595](https://github.com/emberjs/rfcs/issu
 
 ### Application Language Support
 
-<!-- alex ignore easy -->
-
+<!-- alex ignore easy white -->
 The goal of application language support was to provide a mechanism for new Ember apps to pass [WCAG Success Criteria 3.1.1 - Language of Page](https://www.w3.org/TR/WCAG21/#language-of-page). To meet that goal, [Joseph Sumner](https://github.com/josephdsumner), [Jamie White](https://github.com/jgwhite), [Ava Wroten](https://github.com/hergaiety) and [Melanie Sumner](https://github.com/melsumner) authored [RFC 635](https://emberjs.github.io/rfcs/0635-ember-new-lang.html), which proposed a `--lang` flag for `ember-cli`. This flag would enable developers to declare the application's language while they were creating the app, allowing them to more easily meet this particular success criteria. This RFC was merged on June 12th; the feature itself, authored by [Joseph Sumner](https://github.com/josephdsumner) with help from [Rob Jackson](https://github.com/rwjblue), was merged on August 24th.
 
 To add another layer of support and enhance the overall developer experience, the team also decided that it would be useful to have an interactive way to create new Ember apps. After some discussion, [Melanie Sumner](https://github.com/melsumner) authored [RFC 638](https://emberjs.github.io/rfcs/0638-interactive-app-creation.html). The RFC was accepted and merged on August 10th. Implementation is still pending.
@@ -82,4 +81,5 @@ Work is also underway to upscale the addons in the [Ember-A11y GitHub org](https
 
 ## Thank You
 
+<!-- alex ignore white -->
 A huge thank you to all of the community members who participated in the Ember A11y Strike Team: [Abhilash Ramesh](https://github.com/abhilashlr), [Amy Lam](https://github.com/amyrlam), [Ava Wroten](https://github.com/hergaiety), [Benjamin Jegard](https://github.com/kamikillerto), [Emmanuel Patrick](https://github.com/the-bionic), [Eric Kelly](https://github.com/HeroicEric), [Frédéric Soumaré](https://github.com/hakilebara), [Jamie White](https://github.com/jgwhite), [Jen Weber](https://github.com/jenweber), [John Costanzo](https://github.com/jrock2004), [Joseph Sumner](https://github.com/josephdsumner), [Lennex Zinyando](https://github.com/zinyando), [Lenora Porter](https://github.com/lenoraporter), [Melanie Sumner](https://github.com/melsumner), [Praskovia Root](https://github.com/praskovia-root), [Rajasegar Chandran](https://github.com/rajasegar), [Robert Jackson](https://github.com/rwjblue), [Steve Szczecina](https://github.com/steveszc), and [Seema Shariat](https://github.com/seemajune).
diff --git a/content/countdown-to-the-new-year-ember-angle-brackets-codemod.md b/content/countdown-to-the-new-year-ember-angle-brackets-codemod.md
@@ -25,7 +25,7 @@ Before Angle Bracket invocation, nearly every template construct in Ember was in
 1. It visits a URL of your app that is supplied as a command line argument
 2. A small bit of code is injected into the context of the app.
 3. The code identifies the app's components and their properties, as well as all the helpers. This includes those in addons!
-4. Given all this information, the codemod quickly changes all the apps templates preserving most of the whitespace and indentation.
+4. Given all this information, the codemod quickly changes all the apps templates preserving most of the space and indentation.
 
 Here is an example of typical conversion:
 
diff --git a/content/countdown-to-the-new-year-ember-bootstrap-and-ember-paper.md b/content/countdown-to-the-new-year-ember-bootstrap-and-ember-paper.md
@@ -35,6 +35,7 @@ The `ember-bootstrap` addon's clean API's and native Ember components also provi
 
 Writing forms or modals with these components is a very enjoyable experience and has streamlined the code in several of my projects.
 
+<!-- alex ignore trap -->
 Also, recent versions of `ember-bootstrap` have added additional support for improving accessibility by using ember-focus-trap to implement focus trap for modals and keyboard navigation of dropdowns. `ember-bootstrap` has even added ember a11y tests to the addon's test suite!
 
 It gets better, too- `ember-bootstrap` is Octane ready and has refactored it's own components internally to use native classes and angle bracket syntax.
diff --git a/content/ember-1-0-rc6.md b/content/ember-1-0-rc6.md
@@ -39,6 +39,7 @@ For more on new router features, see:
 * [Usage Examples](https://gist.github.com/machty/5647589)
 * [Client-side Authentication Part 2 Embercast](http://www.embercasts.com/episodes/client-side-authentication-part-2)
 
+<!-- alex ignore special -->
 Special thanks to Alex Matchneer for his work on this!
 
 ***Ember Components***
diff --git a/content/ember-1-2-0-and-ember-1-3-0-beta-released.md b/content/ember-1-2-0-and-ember-1-3-0-beta-released.md
@@ -71,10 +71,8 @@ release. You can see a list of all the changes in the CHANGELOG:
 * [Ember.js 1.2.0 CHANGELOG](https://github.com/emberjs/ember.js/blob/v1.2.0/CHANGELOG)
 * [Ember.js 1.3.0 beta 1 CHANGELOG](https://github.com/emberjs/ember.js/blob/v1.3.0-beta.1/CHANGELOG.md)
 
-A very big thank you to everyone who contributed, and a
-special thank you to our release team that have collectively poured
-hours of their free time into automating the infrastructure around the
-release process.
+<!-- alex ignore special -->
+A very big thank you to everyone who contributed, and a special thank you to our release team that have collectively poured hours of their free time into automating the infrastructure around the release process.
 
 As usual, you can always find the latest stable, beta, and canary
 releases at [emberjs.com/builds](/builds).
diff --git a/content/ember-1-8-1-released.md b/content/ember-1-8-1-released.md
@@ -51,6 +51,7 @@ Further Reading:
 
 ### Support rendering of null-prototype objects
 
+<!-- alex ignore special -->
 meta-data objects in Ember-Data are null-prototype, a special kind of object created
 with `Object.create(null)`. In 1.8 these objects could not be rendered. 1.8.1 repairs
 this.
@@ -78,11 +79,13 @@ We've restored support for templates like this:
 </select>
 ```
 
+<!-- alex disable whitespace -->
 ### Known whitespace issues in Chrome
 
 Some templates may result in missing whitespace in Chrome. For example,
 if the following template renders initially with no names, then updates
 via data-binding later, the space between names may not be visible.
+<!-- alex enable whitespace -->
 
 ```handlebars
 {{firstName}} {{lastName}}
diff --git a/content/ember-accessibility-and-a11y-tools.md b/content/ember-accessibility-and-a11y-tools.md
@@ -162,6 +162,7 @@ The problem is that screen readers rely heavily on what has focus. Imagine if yo
 
 It's our responsibility as developers to build inclusive tech, so keep learning and building! [Melanie Sumner's](https://github.com/MelSumner) EmberConf talk [Accessibility for All](https://www.youtube.com/watch?v=6ydNf7e5P00) is a fast, concise introduction to accessibility in Ember, and [this article series](http://www.melsumner.com/blog/accessibility/a11y-accessibility-guide-ember-developers/) provides a deeper dive.
 
+<!-- alex ignore white -->
 There are already many community addons available that solve different issues. While we still have a ways to go, new advances are being made too. For example, there is a [Semantic Test Selectors RFC](https://github.com/emberjs/rfcs/pull/327) being drafted and an [experimental addon](https://github.com/tradegecko/ember-semantic-test-helpers) in development to go with it! These efforts followed [Jamie White's](https://github.com/jgwhite) talk from EmberConf, [Say More](https://www.youtube.com/watch?v=iAyRVPSOpy8).
 
 Almost all of us will have a disability at some point in our lives. Accessible web practices lead to better user experience --- things like improved keyboard navigation, text that is still readable on a dim monitor, and clear pointers on how to interact with a UI.
@@ -183,4 +184,5 @@ Accessible apps are better for everyone.
 
 Our community's improvements are the result of the hard work of many people! Shared solutions take more time to develop, but we can all move forward together.
 
+<!-- alex ignore white -->
 Many thanks to everyone who raises the profile of accessibility in Ember, the team behind a11y addons, contributors involved in getting some features into Ember itself, and those who encourage others to adopt accessible practices. Extra thanks to [Sean Massa](https://github.com/EndangeredMassa), [Melanie Sumner](https://github.com/MelSumner), [Jamie White](https://github.com/jgwhite), and [Robert DeLuca](https://github.com/Robdel12) for reviewing this post.
diff --git a/content/ember-data-1-0-beta-12-released.md b/content/ember-data-1-0-beta-12-released.md
@@ -123,6 +123,7 @@ This change fixed some bugs around observers. Thanks to [Christoffer
 Persson][wecc] for helping to clean this up and fix some observer bugs around
 this!
 
+<!-- alex ignore special -->
 ## Special Thanks
 
 Thanks to [Christoffer Persson][wecc] for helping us implement bugfixes and API
diff --git a/content/ember-data-1-0-beta-14-released.md b/content/ember-data-1-0-beta-14-released.md
@@ -108,8 +108,10 @@ export default DS.RESTSerializer.extend({
 });
 ```
 
+<!-- alex ignore special -->
 ## Special Thanks
 
+<!-- alex ignore special -->
 A special thanks to [Dockyard][dockyard] for sponsoring Igor during the
 month of December!
 
diff --git a/content/ember-data-1-0-beta-9-released.md b/content/ember-data-1-0-beta-9-released.md
@@ -312,12 +312,13 @@ App.CommentAdapter = DS.RestAdapter.extend({
 
 For more information, go to [Store documentation][store-docs].
 
+<!-- alex ignore special -->
 ## Special Thanks
 
 We'd like to thank the following members of the Ember.js community for their
 continued contributions to Ember Data:
 
-* Igor Terzic as the project's main steward (@terzicigor)
+* Igor Terzic as the project's main contributor (@terzicigor)
 * Brendan McLoughlin (@BezoMaxo) for responding to and triaging issues, and
   contributing documentation, bug fixes, and improvements.
 * Ilya Radchenko (@knownasilya)
diff --git a/content/ember-data-1-13-released.md b/content/ember-data-1-13-released.md
@@ -80,6 +80,7 @@ of the deprecations for you.
 **Ember Data 1.13 is the last release of Ember Data that supports IE8
   and the 1.x series of Ember.js. Ember Data 2.0-beta.1 will be released shortly, and it will follow the Ember.js release train.** Ember Data 2.0 will not work with the Ember.js 1.x series.
 
+<!-- alex ignore special -->
 We would like to extend a special thanks to the many contributors who
 have helped out with this release. We would also like to recognize the
 following contributors who helped with multiple issues leading up to
diff --git a/content/ember-fastboot-1-0-release.md b/content/ember-fastboot-1-0-release.md
@@ -48,4 +48,5 @@ By enhancing Ember CLI public API and taking advantage of those new capabilities
 
 With this, please check out the Ember FastBoot [website](http://ember-fastboot.com) to learn more on how to make your Ember apps work in FastBoot. If you find any issues, please open issues in the appropriate repository in [ember-fastboot](https://github.com/ember-fastboot).
 
+<!-- alex ignore white -->
 This release wouldn’t have been possible without the help, support and feedback of the awesome Ember community. We also would not have been able to make FastBoot better without the vision and guidance of [Tom Dale](http://github.com/tomdale), [Stefan Penner](https://github.com/stefanpenner), [Robert Jackson](https://github.com/rwjblue) and the entire Ember CLI core team. Thanks to [Arjan Singh](https://github.com/arjansingh), [Dan McClain](https://github.com/danmcclain), [Hassan Abdel-Rahman](https://github.com/habdelra), [Kelly Selden](https://github.com/kellyselden), [Marco Otte-Witte](https://github.com/marcoow), [Patrick Fisher](https://github.com/pwfisher), [Ron White](https://github.com/ronco), [Simon Ihmig](https://github.com/simonihmig), [Tsubomi Imamura](https://github.com/tsubomii), [Travis Hoover](https://github.com/thoov) and many other contributors who helped along the way.
diff --git a/content/ember-node-lts-support.md b/content/ember-node-lts-support.md
@@ -8,7 +8,7 @@ tags:
   - '2016'
 ---
 
-
+<!-- alex ignore steward-stewardess -->
 Ember is committed to being a good steward of our collective codebases as part of the [Node.js](https://nodejs.org/en/) [ecosystem](https://www.npmjs.com/). In that spirit we will be following the [Node.js Long Term Support Schedule](https://github.com/nodejs/LTS#lts-schedule) to provide clear guarantees of which versions of Node.js we support and how long we will support them. We will test against the same set of releases which the Node.js Long-term Support Working Group says they support: any "Current", "Active LTS", or "Maintenance" releases.
 
 ### What does support mean?
@@ -47,4 +47,5 @@ We don't presently rely upon transpilation to support older versions of the Node
 
 Further, if we find ourselves maintaining our own forks or depending upon legacy versions of much of the JavaScript ecosystem, we reserve the option to change our approach in the future. As always we will be paying close attention to the community's needs and will give at least a six month notice of any change to this stated support policy.
 
+<!-- alex ignore special -->
 _Special thanks to [Hannah Wolfe](https://github.com/ErisDS) for helping direct us to this approach._
diff --git a/content/emberconf-2017-state-of-the-union.md b/content/emberconf-2017-state-of-the-union.md
@@ -222,6 +222,7 @@ Benchmarks are essential to measuring our performance improvements, but benchmar
 
 [V8's Benedikt Meurer has a fantastic blog post about their new Ignition + TurboFan architecture](http://benediktmeurer.de/2017/03/01/v8-behind-the-scenes-february-edition/), and how years of benchmark competition had caused them to be "over-focused on the peak performance case" while "baseline performance was a blind spot."
 
+<!-- alex ignore trap -->
 JavaScript libraries can fall into the same trap too. Community discussion often ends up focused around one measurement, which libraries then feel obligated to optimize for.
 
 For example, a few years ago it was updating performance and the infamous `dbmon` demo.
diff --git a/content/glimmer-merging.md b/content/glimmer-merging.md
@@ -131,7 +131,7 @@ part because of the simplification of the overall model.
 us, exceeding the improvements we've seen in benchmarks designed to
 stress-test pathological cases.**
 
-When upgrading to Glimmer, please pay special attention to the
+When upgrading to Glimmer, please pay attention to the
 real-world performance of your application **in production mode** and
 after clearing any deprecations with performance warnings.
 
diff --git a/content/handlebars-update.md b/content/handlebars-update.md
@@ -13,13 +13,15 @@ requests to update Ember to allow the use of the latest version.  Handlebars 2.0
 a number of changes the list below represents a few that are likely to affect your
 Ember application:
 
+<!-- alex disable whitespace -->
 * Precompiler output has changed, which breaks compatibility with prior versions of the
   runtime and precompiled output.
 * A JSON polyfill is required to run the compiler in IE8 and below. It's recommended
   that the precompiler be used in lieu of running the compiler on these legacy environments.
 * Lines containing only block statements and whitespace are now removed. This matches the
   Mustache spec but may cause issues with code that expects whitespace to exist but would
   not otherwise.
+<!-- alex enable whitespace -->
 
 For more information about the changes please review the [release notes](https://github.com/wycats/handlebars.js/blob/master/release-notes.md).
 
diff --git a/content/the-ember-times-issue-124.md b/content/the-ember-times-issue-124.md
@@ -81,6 +81,7 @@ Do you have any feedback? Feel free to reach out to [Mehul Kar (@mehulkar)](http
 
 A few weeks ago, [Simon Ihmig (@simonihmig)](https://github.com/simonihmig) and the folks at [kaliber5](https://github.com/kaliber5) released version 3.1.0 of the fantastic Ember addon [ember-bootstrap](https://github.com/kaliber5/ember-bootstrap).
 
+<!-- alex ignore trap -->
 This version focuses on **improving accessibility** by using [ember-focus-trap](https://github.com/josemarluedke/ember-focus-trap) to implement focus trap for modals and keyboard navigation of dropdowns. It also adds [ember a11y tests](https://github.com/ember-a11y/ember-a11y-testing) to the test suite! 🔥🔥🔥
 
 Many thanks to all those that contributed to this release and the accessiblity concerns addressed by it 😄, including [Simon Ihmig (@simonihmig)](https://github.com/simonihmig), [Brad Overton (@techn1x)](https://github.com/Techn1x), [Ramiz Wachtler (@rwachtler)](https://github.com/rwachtler) and [Jeldrik Hanschke (@jelhan)](https://github.com/jelhan).
diff --git a/content/the-ember-times-issue-98.md b/content/the-ember-times-issue-98.md
@@ -122,13 +122,15 @@ We encourage you to [read and share the blog post](https://medium.com/ember-ish/
 
 ---
 
+<!-- alex disable trap -->
 ## [Intentional Element Focus with Ember Focus Trap 💥](https://twitter.com/josemarluedke/status/1127967059415953408)
 
 On May 16th, **Global Accessibility Awareness Day (GAAD)** inspired developers all around the world to reflect on the way they use and build applications for the web. In her [recent call-to-action for GAAD](https://blog.emberjs.com/2019/05/13/global-accessibility-awareness-day.html) 📣, [@MelSumner](https://github.com/MelSumner) encouraged the Ember community to take the time to browse the web using keyboard or an assistive technology, and to spend time to improve accessibility in their own projects.
 
 Addon author [@josemarluedke](https://github.com/josemarluedke) followed this call-to-action and published [Ember Focus Trap](https://github.com/josemarluedke/ember-focus-trap)! It's based on the JavaScript library [Focus Trap](https://github.com/davidtheclark/focus-trap) that helps you to intentionally trap focus in certain DOM nodes. This helps you improve the keyboard accessibility of otherwise inaccessible elements such as modal dialogs.
 
 With **Ember Focus Trap**, adding focus to interactive elements in your Ember app is only an `ember install` away. Check it [out today](https://josemarluedke.github.io/ember-focus-trap/)!
+<!-- alex enable trap -->
 
 ---
 
diff --git a/content/this-week-in-ember-js-4.md b/content/this-week-in-ember-js-4.md
@@ -134,7 +134,7 @@ several steps:
 ## Documentation
 
 Perhaps the most widespread feedback we received from developers was:
-_"Ember.js looks really cool, but your documentation sucks."_ We heard
+_"Ember.js looks really cool, but your documentation is not."_ We heard
 you loud and clear.
 
 We recently launched the [completely redesigned Guides][5], and due to
