Skip to content

Removing the tabbed-layout and moving it to an on-this-page layout #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: website-redesign
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
323cb8e
Update styleguide to have the on-this-page styling
MinThaMie Jun 14, 2024
8a98942
Move private toggle up in the sidebar
MinThaMie Jun 14, 2024
b87e1d0
move templates to components + remove EmberAnchor from the templates …
MinThaMie Jun 14, 2024
49a3cba
Make styling work, remove ember-anchor + updateAnchor implementation
MinThaMie Jun 14, 2024
fbe8859
fix pnpm version
mansona Jul 11, 2024
ae125c6
delete all scroll-tracker stuff
mansona Jul 11, 2024
36e1d6c
remove all traces of ember-anchor
mansona Jul 11, 2024
791a69c
Fix function layout
MinThaMie Jul 26, 2024
2483a9c
Merge 'origin/website-redesign' into layout
mansona May 24, 2025
50a3342
add redirects for methods
mansona Oct 15, 2024
5873677
fix redirects
mansona May 22, 2025
4015814
speed up builds
mansona May 24, 2025
0391a39
Add all method, properties & events redirects to classes, modules, na…
MinThaMie May 24, 2025
9b7e6ad
Merge pull request #931 from ember-learn/test-redirects
MinThaMie May 24, 2025
e2ceca9
WIP stuff
MinThaMie May 24, 2025
0324674
Tiny bit of CSS, fix pnpm-lock and route file after merge
MinThaMie May 24, 2025
9675bf5
Fix linting
MinThaMie May 24, 2025
2d3415d
remove events, methods, properties sub-routes
mansona May 26, 2025
bdbac7d
remove unused function
mansona May 26, 2025
ea43141
remove unused packages
mansona May 26, 2025
1b255ae
update the ember landing page to use anchors correctly
mansona May 26, 2025
0f8f1be
remove unused Percy snapshots
mansona May 26, 2025
6082c26
Merge pull request #951 from ember-learn/remove-routes
mansona May 26, 2025
4f03c69
fix namespace percy snapshot
mansona May 29, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
delete all scroll-tracker stuff
  • Loading branch information
mansona authored and MinThaMie committed Jul 25, 2024
commit ae125c65512ee2e76adc30390883665e124cf8da
42 changes: 0 additions & 42 deletions app/mixins/scroll-tracker.js

This file was deleted.

4 changes: 2 additions & 2 deletions app/routes/project-version/classes/class.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@ import { inject as service } from '@ember/service';
import { resolve, all } from 'rsvp';
import Route from '@ember/routing/route';
import { set } from '@ember/object';
import ScrollTracker from 'ember-api-docs/mixins/scroll-tracker';

import { pluralize } from 'ember-inflector';
import getFullVersion from 'ember-api-docs/utils/get-full-version';
import createExcerpt from 'ember-api-docs/utils/create-excerpt';

export default class ClassRoute extends Route.extend(ScrollTracker) {
export default class ClassRoute extends Route {
/** @type {import('@ember/routing/router-service').default} */
@service
router;
Expand Down
7 changes: 0 additions & 7 deletions app/routes/project-version/functions/function.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@ export default class FunctionRoute extends Route {
@service
metaStore;

@service
scrollPositionReset;

titleToken(model) {
return model?.fn?.name;
}
Expand Down Expand Up @@ -63,8 +60,4 @@ export default class FunctionRoute extends Route {
return fn.name === functionName;
});
}

activate() {
this.scrollPositionReset.doReset();
}
}
3 changes: 1 addition & 2 deletions app/routes/project-version/modules/module.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import ClassRoute from '../classes/class';
import ScrollTracker from 'ember-api-docs/mixins/scroll-tracker';
import getFullVersion from 'ember-api-docs/utils/get-full-version';

export default class ModuleRoute extends ClassRoute.extend(ScrollTracker) {
export default class ModuleRoute extends ClassRoute {
async model(params) {
const { project, project_version: compactVersion } =
this.paramsFor('project-version');
Expand Down
3 changes: 1 addition & 2 deletions app/routes/project-version/namespaces/namespace.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import ClassRoute from '../classes/class';
import ScrollTracker from 'ember-api-docs/mixins/scroll-tracker';
import getFullVersion from 'ember-api-docs/utils/get-full-version';

export default class NamespaceRoute extends ClassRoute.extend(ScrollTracker) {
export default class NamespaceRoute extends ClassRoute {
templateName = 'project-version/classes/class';

async model(params) {
Expand Down
3 changes: 1 addition & 2 deletions app/routes/project.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import Route from '@ember/routing/route';
import ScrollTracker from 'ember-api-docs/mixins/scroll-tracker';
import { inject as service } from '@ember/service';

export default class ProjectRoute extends Route.extend(ScrollTracker) {
export default class ProjectRoute extends Route {
/** @type {import('@ember/routing/router-service').default} */
@service
router;
Expand Down
72 changes: 0 additions & 72 deletions app/services/scroll-position-reset.js

This file was deleted.

12 changes: 0 additions & 12 deletions tests/unit/mixins/scroll-tracker-test.js

This file was deleted.