#135 #138
Merged
#135 #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chancancode
reviewed
Oct 3, 2019
chancancode
reviewed
Oct 3, 2019
chancancode
reviewed
Oct 3, 2019
Co-Authored-By: Godfrey Chan <godfreykfc@gmail.com>
Co-Authored-By: Godfrey Chan <godfreykfc@gmail.com>
chancancode
reviewed
Oct 4, 2019
chancancode
reviewed
Oct 4, 2019
Co-Authored-By: Godfrey Chan <godfreykfc@gmail.com>
chancancode
reviewed
Oct 4, 2019
Co-Authored-By: Godfrey Chan <godfreykfc@gmail.com>
chancancode
approved these changes
Oct 4, 2019
|
@chancancode I am wondering if we should refer to this as "classic" layout if we are showing Octane's structure in it. What do you think about calling it "default layout?" |
|
Also thanks for this work @lifeart! |
|
@jenweber I think that would be great! (I also think it would be great if we can more strongly discourage people from using pods, but I suppose that's a whole different conversation for another time 😬) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#135 @jenweber