Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ember-cli/eslint-plugin-ember
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v8.9.1
Choose a base ref
...
head repository: ember-cli/eslint-plugin-ember
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v8.9.2
Choose a head ref
  • 13 commits
  • 11 files changed
  • 1 contributor

Commits on Jul 15, 2020

  1. chore(lint): add npm-package-json-lint

    @bmish
    bmish committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    82c0ec5 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #888 from bmish/npm-package-json-lint 

    Add npm-package-json-lint
    @bmish
    bmish authored Jul 15, 2020
    Configuration menu
    Copy the full SHA
    0183d45 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2020

  1. chore(lint): remove lint:docs-js script which is no longer needed wit… 

    …h ESLint 7

https://eslint.org/docs/user-guide/migrating-to-7.0.0#lint-files-matched-by-overrides-files-by-default
    @bmish
    bmish committed Jul 19, 2020
    Configuration menu
    Copy the full SHA
    2a001c4 View commit details
    Browse the repository at this point in the history

  2. docs: switch from redundant dynamic error message to static error mes… 

    …sage in no-get rule

Maintaining a dynamic error message showing the before and after code has become a burden to maintain given the many variations / options / edge cases that the `no-get` has grown to support.

It's also redundant to show the before and after code, given that the user already knows what the before code is, and the rule can autofix to the recommended code.
    @bmish
    bmish committed Jul 19, 2020
    Configuration menu
    Copy the full SHA
    18538ca View commit details
    Browse the repository at this point in the history

  3. Merge pull request #892 from bmish/no-get-static-error-message 

    Switch from unnecessary dynamic error message to static error message in `no-get` rule
    @bmish
    bmish authored Jul 19, 2020
    Configuration menu
    Copy the full SHA
    aa7b664 View commit details
    Browse the repository at this point in the history

  4. fix: support array element access in no-get autofix

    @bmish
    bmish committed Jul 19, 2020
    Configuration menu
    Copy the full SHA
    9b2ca49 View commit details
    Browse the repository at this point in the history

  5. fix: ensure no-attrs-in-components rule only runs inside components

    @bmish
    bmish committed Jul 19, 2020
    Configuration menu
    Copy the full SHA
    b718821 View commit details
    Browse the repository at this point in the history

  6. fix: no-test-import-export rule should allow importing from anything … 

    …under tests/helpers path
    @bmish
    bmish committed Jul 19, 2020
    Configuration menu
    Copy the full SHA
    68470e0 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2020

  1. Merge pull request #893 from bmish/no-get-array-access 

    Support array element access in `no-get` rule autofix
    @bmish
    bmish authored Jul 20, 2020
    Configuration menu
    Copy the full SHA
    9e32b9f View commit details
    Browse the repository at this point in the history

  2. Merge pull request #894 from bmish/no-attrs-in-components-scoping 

    Ensure `no-attrs-in-components` rule only runs inside components
    @bmish
    bmish authored Jul 20, 2020
    Configuration menu
    Copy the full SHA
    c1650b5 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #895 from bmish/no-test-import-export-helpers-fix 

    Update `no-test-import-export` rule to allow importing from anything under `tests/helpers` path
    @bmish
    bmish authored Jul 20, 2020
    Configuration menu
    Copy the full SHA
    7701b2b View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2020

  1. Update CHANGELOG

    @bmish
    bmish committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    49b9757 View commit details
    Browse the repository at this point in the history

  2. v8.9.2

    @bmish
    bmish committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    27fcd01 View commit details
    Browse the repository at this point in the history
Loading