Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ember-cli/eslint-plugin-ember
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v8.10.1
Choose a base ref
...
head repository: ember-cli/eslint-plugin-ember
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v8.11.0
Choose a head ref
  • 10 commits
  • 31 files changed
  • 1 contributor

Commits on Aug 8, 2020

  1. fix: check imports when detecting computed properties in many rules 

    Updates our Ember util function `isComputedProp` to consider the names that `Ember` and `computed` are imported under instead of assuming they are imported under the standard names. This util function is used in 10 rules.
    @bmish
    bmish committed Aug 8, 2020
    Configuration menu
    Copy the full SHA
    98090d5 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2020

  1. Merge pull request #909 from bmish/computed-property-import-checks 

    Check imports when detecting computed properties in many rules
    @bmish
    bmish authored Aug 9, 2020
    Configuration menu
    Copy the full SHA
    0e44781 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2020

  1. fix: update no-test-import-export rule to allow importing from anythi… 

    …ng under tests/helpers path when using relative path
    @bmish
    bmish committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    2998e44 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2020

  1. fix: add catchSafeObjects option to no-get rule to catch usages o… 

    …f the imported get/getProperties functions on non-this objects
    @bmish
    bmish committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    756bf78 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #912 from bmish/no-get-imported-fn-this 

    Add `catchSafeObjects` option (default false) to `no-get` rule to catch usages of the imported get/getProperties functions on non-this objects
    @bmish
    bmish authored Aug 13, 2020
    Configuration menu
    Copy the full SHA
    9334f3a View commit details
    Browse the repository at this point in the history

  3. Merge pull request #911 from bmish/no-test-import-export-helpers-fix-2 

    Update `no-test-import-export` rule to allow importing from anything under `tests/helpers` path (when using relative path)
    @bmish
    bmish authored Aug 13, 2020
    Configuration menu
    Copy the full SHA
    50bdf60 View commit details
    Browse the repository at this point in the history

  4. feat: add catchUnsafeObjects option to no-get rule

    @bmish
    bmish committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    af59282 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2020

  1. Merge pull request #913 from bmish/no-get-unsafe-objects 

    Add `catchUnsafeObjects` option (default false) to `no-get` rule to catch `foo.get('bar')`
    @bmish
    bmish authored Aug 14, 2020
    Configuration menu
    Copy the full SHA
    66a27a8 View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG

    @bmish
    bmish committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    9369373 View commit details
    Browse the repository at this point in the history

  3. v8.11.0

    @bmish
    bmish committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    f6fa1aa View commit details
    Browse the repository at this point in the history
Loading