Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module unification: initializer test files are included for ember serve #47

Closed
ghost opened this issue Dec 19, 2017 · 2 comments
Closed

module unification: initializer test files are included for ember serve #47

ghost opened this issue Dec 19, 2017 · 2 comments

Comments

@ghost
Copy link

ghost commented Dec 19, 2017

Relates to #42. Mistakenly opened here: ember-cli/ember-cli-chai#37.

reproduction

  1. clone the reproduction repo git clone --single-branch -b bug-initializer-test https://github.com/efx/poc-bug.git && cd poc-bug && npm install && bower install
  2. run ember build or ember serve
  3. Notice that the initalizer test files are being included when they shouldn't.

screen shot 2017-12-19 at 9 28 02 am
@rwjblue
Copy link
Member

rwjblue commented Dec 19, 2017

Seems like we need to allow excludes? 🤔

@ghost ghost mentioned this issue Apr 2, 2018
Closed
22 tasks
@ghost ghost mentioned this issue Apr 16, 2018
Merged
@rwjblue
Copy link
Member

rwjblue commented Apr 17, 2018

Closed by #53

@rwjblue rwjblue closed this as completed Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rwjblue