Skip to content

Commit 2477977

Browse files
authored
Merge pull request #171 from ember-cli/improve-error-message
Improve error message
2 parents 8c66659 + f0f9d4a commit 2477977

File tree

2 files changed

+13
-4
lines changed

2 files changed

+13
-4
lines changed

src/project-wide-dependency-checker.js

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,16 @@ module.exports = class ProjectWideDependencyChecker {
6161
return true;
6262
}
6363

64-
let message =
65-
customMessage ||
66-
`[ember-cli-version-checker] This project requires a single implementation version of the npm package \`${name}\`, but there're multiple. Please resolve \`${name}\` to same version:`;
67-
64+
let message;
65+
if (uniqueImplementations.size < 1) {
66+
message = `[ember-cli-version-checker] This project requires a single implementation version of the npm package \`${name}\`, but none where found.`;
67+
} else {
68+
if (customMessage) {
69+
message = customMessage;
70+
} else {
71+
message = `[ember-cli-version-checker] This project requires a single implementation version of the npm package \`${name}\`, but there're multiple. Please resolve \`${name}\` to same version:`;
72+
}
73+
}
6874
for (let root of uniqueImplementations) {
6975
message += `\n - ${name} @ ${root}`;
7076
}

tests/index-tests.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -452,6 +452,9 @@ describe('ember-cli-version-checker', function() {
452452
});
453453

454454
it('#assertSingleImplementation throws correctly', function() {
455+
assert.throws(() => {
456+
checker.assertSingleImplementation('--no-such-addon--');
457+
}, /This project requires a single implementation version of the npm package `--no-such-addon--`, but none where found./);
455458
assert.throws(() => {
456459
checker.assertSingleImplementation('bar');
457460
}, /This project requires a single implementation version of the npm package `bar`, but there're multiple. Please resolve `bar` to same version./);

0 commit comments

Comments
 (0)