Fix invalid atime being set #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not super clear from the node docs, but it appears that the value of atime needs to be in seconds since the eppoc, but Date.now returns milliseconds which sets the timestamp far into the future. This causes node tar to die when it attempts to encode this time and finds a very large integer. We can also pass a Date object directly here so that's what I've done.
avdv
approved these changes
Nov 11, 2021
lukemelia
approved these changes
Nov 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed & Why
It's not super clear from the node docs, but it appears that the value
of atime needs to be in seconds since the eppoc, but Date.now returns milliseconds
which sets the timestamp far into the future. This causes node tar to
die when it attempts to encode this time and finds a very large integer.
We can also pass a Date object directly here so that's what I've done.
This could also copy the access time in the same way we copy the modified time, but it seems better to set it to the created time instead. I'm happy to go either way though.
Related issues
Link to related issues in this or other repositories (if any)
PR Checklist
People
@avdv @lukemelia