display new scm revisionData #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 19, 2016
| @@ -18,100 +20,22 @@ module.exports = { | |||
| }, | |||
|
|
|||
| displayRevisions: function(context) { | |||
| if(!context.revisions) { | |||
| if(!context.revisions || context.revisions.length === 0) { | |||
There was a problem hiding this comment.
We should consider accessing this via readConfig
There was a problem hiding this comment.
I might still be asleep but I don't think we can do that
https://github.com/ember-cli-deploy/ember-cli-deploy-plugin/blob/master/index.js#L45
ghedamat
force-pushed
the
enrich-revision-data
branch
5 times, most recently
from
36b33dd to
e8c4da7
Compare
|
Looks good! |
moves old behaviour in separate file as well
ghedamat
force-pushed
the
enrich-revision-data
branch
from
e8c4da7 to
ca41efe
Compare
|
@lukemelia updated with readme |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see
ember-cli-deploy/ember-cli-deploy#305
ember-cli-deploy/ember-cli-deploy-redis#56
ember-cli-deploy/ember-cli-deploy-revision-data#29
NOTE:
to render properly this needs
ember-cli-deploy/ember-cli-deploy-plugin#9