Fixes ember eslint violations

Author: Andrew Lee

.travis.yml

@@ -22,9 +22,9 @@ env:
   jobs:
     # we recommend new addons test the current and previous LTS
     # as well as latest stable release (bonus points to beta/canary)
-    - EMBER_TRY_SCENARIO=ember-lts-2.18
     - EMBER_TRY_SCENARIO=ember-lts-3.4
     - EMBER_TRY_SCENARIO=ember-lts-3.8
+    - EMBER_TRY_SCENARIO=ember-lts-3.12
     - EMBER_TRY_SCENARIO=ember-release
     - EMBER_TRY_SCENARIO=ember-beta
     - EMBER_TRY_SCENARIO=ember-canary

addon/instance-initializers/axe-component.js

@@ -121,8 +121,8 @@ export function initialize(appInstance) {
      */
     violationClasses: computed('axeViolationClassNames', 'visualNoiseLevel', {
       get() {
-        const customViolationClass = this.get('axeViolationClassNames');
-        const visualNoiseLevel = this.get('visualNoiseLevel');
+        const customViolationClass = this.axeViolationClassNames;
+        const visualNoiseLevel = this.visualNoiseLevel;
 
         if (visualNoiseLevel < 1) {
           return null;
@@ -148,9 +148,9 @@ export function initialize(appInstance) {
      * @return {Void}
      */
     audit() {
-      if (this.get('tagName') !== '') {
+      if (this.tagName !== '') {
         concurrentAxe.run(this.element, this.axeOptions, (error, results) => {
-          if (this.get('isDestroyed')) {
+          if (this.isDestroyed) {
             return;
           }
 
@@ -159,8 +159,8 @@ export function initialize(appInstance) {
           }
 
           const violations = results.violations;
-          const violationClasses = this.get('violationClasses') || [];
-          const visualNoiseLevel = this.get('visualNoiseLevel');
+          const violationClasses = this.violationClasses || [];
+          const visualNoiseLevel = this.visualNoiseLevel;
 
           let violation;
           let nodes;

config/ember-try.js

@@ -7,37 +7,36 @@ module.exports = async function() {
     useYarn: true,
     scenarios: [
       {
-        name: 'ember-lts-2.18',
+        name: 'ember-lts-3.4',
         env: {
           EMBER_OPTIONAL_FEATURES: JSON.stringify({ 'jquery-integration': true }),
         },
         npm: {
           devDependencies: {
             '@ember/jquery': '^0.5.1',
-            'ember-source': '~2.18.0'
+            'ember-source': '~3.4.0'
           }
         }
       },
       {
-        name: 'ember-lts-3.4',
+        name: 'ember-lts-3.8',
         env: {
           EMBER_OPTIONAL_FEATURES: JSON.stringify({ 'jquery-integration': true }),
         },
         npm: {
           devDependencies: {
-            '@ember/jquery': '^0.5.1',
-            'ember-source': '~3.4.0'
+            'ember-source': '~3.8.0'
           }
         }
       },
       {
-        name: 'ember-lts-3.8',
+        name: 'ember-lts-3.12',
         env: {
           EMBER_OPTIONAL_FEATURES: JSON.stringify({ 'jquery-integration': true }),
         },
         npm: {
           devDependencies: {
-            'ember-source': '~3.8.0'
+            'ember-source': '~3.12.0'
           }
         }
       },

tests/integration/helpers/a11y-audit-test.js

@@ -7,14 +7,6 @@ import a11yAudit from 'ember-a11y-testing/test-support/audit';
 module('Integration | Helper | a11yAudit', function(hooks) {
   setupRenderingTest(hooks);
 
-  if (typeof jQuery != 'undefined') {
-    test('a11yAudit runs successfully with jquery context', async function(assert) {
-      await render(hbs`{{#axe-component}}{{/axe-component}}`);
-      await a11yAudit(this.$());
-      assert.ok(true, 'a11yAudit ran and didn\'t find any issues');
-    });
-  }
-
   test('a11yAudit runs successfully with element context', async function(assert) {
     await render(hbs`{{#axe-component}}{{/axe-component}}`);
     await a11yAudit(this.element);