Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTCPServer::Send can result in SIGPIPE #16

Open
logidelic opened this issue Apr 7, 2021 · 2 comments
Open

CTCPServer::Send can result in SIGPIPE #16

logidelic opened this issue Apr 7, 2021 · 2 comments

Comments

@logidelic
Copy link

First, thanks for this project. Quite useful.

One issue I've noticed so far: If the connection gets disconnected for some reason just before a CTCPServer::Send call, then Send will result in a SIGPIPE under Linux, aborting the program.

Instead, this should be handled gracefully (ex Send should return an error).

@logidelic
Copy link
Author

Thanks for that. Yea, for the send call, I ended up changing the flags passed to MSG_NOSIGNAL (I think recv needs the same). IMO this be the default for this lib, but I'll let you decide. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants