Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add features from png-target #25

Merged
merged 2 commits into from
May 4, 2021
Merged

Conversation

rfuest
Copy link
Member

@rfuest rfuest commented May 3, 2021

This PR adds the features from tools/png-target in the e-g repo, like base64 and grayscale output, to the simulator PNG output. This reduces code duplication and adds support for OutputSettings to the PNG export.

@rfuest rfuest requested a review from jamwaffles May 3, 2021 19:10
Copy link
Member

@jamwaffles jamwaffles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The examples are clean and concise too, nice work.

@rfuest
Copy link
Member Author

rfuest commented May 4, 2021

Thanks! Could you release a new simulator beta, so that I can port some tools to use the simulator instead of png-target?

@rfuest rfuest merged commit 636947f into embedded-graphics:master May 4, 2021
@rfuest rfuest deleted the png-target branch May 4, 2021 00:01
@jamwaffles
Copy link
Member

Done! 0.3.0-beta.2 is out now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants