Rustup #80
Merged
Rustup #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-opp
reviewed
Feb 25, 2019
Contributor
phil-opp
left a comment
phil-opp
left a comment
There was a problem hiding this comment.
Looks good to me!
I pushed a small update to ignore DHCP packets in the poll_socket function (instead of panicking in unreachable). The networking code still doesn't work for me: The DHCP server sends a NAK with message "lease not found" on every DHCP request. I assume that this is a bug in the smoltcp branch, so I added a comment in smoltcp-rs/smoltcp#186 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @phil-opp
fixes #79