Skip to content

Commit cb94f64

Browse files
committed
move and rename bazel rc file, upstream location changed
update aws client lib patch based on upstream changes move libevent build file override, upstream location changed udpate file overrides in dockerfile
1 parent 514bf5f commit cb94f64

File tree

6 files changed

+18
-16
lines changed

6 files changed

+18
-16
lines changed

tools/bazel.rc renamed to .bazelrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ build --define=grpc_no_ares=true
3131

3232
build -c opt
3333

34-
# Adding --cxxopt=-D_GLIBCXX_USE_CXX11_ABI=0 creates parity with TF
34+
# Adding --cxxopt=-D_GLIBCXX_USE_CXX11_ABI=0" creates parity with TF
3535
# compilation options. It also addresses memory use due to
3636
# copy-on-write semantics of std::strings of the older ABI.
3737
build --cxxopt=-D_GLIBCXX_USE_CXX11_ABI=0

WORKSPACE

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,13 @@ load("//tensorflow_serving:repo.bzl", "tensorflow_http_archive")
1111

1212
tensorflow_http_archive(
1313
name = "org_tensorflow",
14-
sha256 = "5aae44f967556dc524e6b184643bbd33a2d78184bc654b72c09f041f266b89a2",
15-
git_commit = "a6d8ffae097d0132989ae4688d224121ec6d8f35",
16-
patches = ["aws.BUILD.patch"]
14+
sha256 = "9345658274058773f34a8865fba14b9fdd3c1c4cb3eaf44dbb7f6c01632ee830",
15+
git_commit = "6612da89516247503f03ef76e974b51a434fb52e",
16+
patches = ["aws.BUILD.bazel.patch"]
1717
)
1818

19+
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
20+
1921
# TensorFlow depends on "io_bazel_rules_closure" so we need this here.
2022
# Needs to be kept in sync with the same target in TensorFlow's WORKSPACE file.
2123
http_archive(
@@ -36,4 +38,4 @@ tf_serving_workspace()
3638
# Specify the minimum required bazel version.
3739
load("@org_tensorflow//tensorflow:version_check.bzl", "check_bazel_version_at_least")
3840

39-
check_bazel_version_at_least("0.15.0")
41+
check_bazel_version_at_least("0.20.0")

external/aws.BUILD.patch renamed to external/aws.BUILD.bazel.patch

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
--- third_party/aws.BUILD 2018-09-24 10:49:26.000000000 -0700
2-
+++ aws.BUILD 2018-10-30 12:41:38.000000000 -0700
1+
--- third_party/aws/BUILD.bazel 2019-03-29 13:04:47.000000000 -0700
2+
+++ aws.BUILD.bazel 2019-03-29 13:10:11.000000000 -0700
33
@@ -11,21 +11,8 @@
4-
4+
55
cc_library(
66
name = "aws",
77
- srcs = select({

tensorflow_serving/repo.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
""" TensorFlow Http Archive
22
3-
Modified http_arhive that allows us to override the TensorFlow commit that is
3+
Modified http_archive that allows us to override the TensorFlow commit that is
44
downloaded by setting an environment variable. This override is to be used for
55
testing purposes.
66

tensorflow_serving/tools/docker/Dockerfile.arm

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,27 +15,27 @@ ARG ARCH=arm64v8
1515
ARG TFS_VERSION=latest
1616
FROM tensorflow/serving:$TFS_VERSION-devel as devel
1717
# install arm toolchain dependencies
18+
ENV TF_ENABLE_XLA=0
1819
COPY tensorflow_serving/tools/docker/install_arm_toolchain.sh /install_arm_toolchain.sh
1920
RUN /install_arm_toolchain.sh
2021
# overwrite existing sources
2122
# adds config groupings with default options for arm32v7 and arm64v8
22-
COPY tools/bazel.rc /tensorflow-serving/tools/bazel.rc
23-
# uses bazelrc make variables to get arch specific flags
24-
COPY third_party/libevent.BUILD /tensorflow-serving/third_party/libevent.BUILD
23+
COPY .bazelrc /tensorflow-serving/.bazelrc
24+
# uses bazelrc make variables to get arch specific compile flags
25+
COPY third_party/libevent/BUILD /tensorflow-serving/third_party/libevent/BUILD
2526
# implements bazel external source patching for aws client libs
2627
COPY WORKSPACE /tensorflow-serving/WORKSPACE
2728
COPY tensorflow_serving/repo.bzl /tensorflow-serving/tensorflow_serving/repo.bzl
28-
COPY external/aws.BUILD.patch /tensorflow-serving/external/aws.BUILD.patch
29-
# backport upstream patch for gzip implementation causing build failures for 32-bit
30-
COPY tensorflow_serving/util/net_http/server/internal/evhttp_request.cc /tensorflow-serving/tensorflow_serving/util/net_http/server/internal/evhttp_request.cc
29+
COPY external/aws.BUILD.bazel.patch /tensorflow-serving/external/aws.BUILD.bazel.patch
3130
# add new sources
3231
# adds bazel C++ toolchains for armhf and arm64
3332
COPY tools/cpp /tensorflow-serving/tools/cpp
3433

3534
FROM devel as build
3635
ARG ARCH
3736
ARG BUILD_OPTS
38-
RUN bazel build --verbose_failures --config=${ARCH} ${BUILD_OPTS} tensorflow_serving/model_servers:tensorflow_model_server
37+
RUN bazel build --verbose_failures --output_filter=DONT_MATCH_ANYTHING --config=${ARCH} \
38+
${BUILD_OPTS} tensorflow_serving/model_servers:tensorflow_model_server
3939

4040
FROM ${ARCH}/debian:stretch-slim as tensorflow_model_server
4141
# Install TF Serving binary
File renamed without changes.

0 commit comments

Comments
 (0)