Split keybindings out from evil-integration

[jojojames]

@edkolev @Ambrevar @noctuid @justbur @wasamasa @syl20bnr @TheBB

Following from: emacs-evil/evil-collection#60

Most everyone seems to be on board to pull the keybindings out so that evil-collection can more easily leverage evil's evil-integration.el.

I took a quick look and pulled out the keybindings from evil-integration and put them in a separate file.

Any comments appreciated!

[TheBB]

If evil-collection finds this useful I'm ok with it.

[noctuid]

Maybe also move the ELP configuration? Right now the configuration for changing the initial ag state to motion has been moved, but the elp configuration for entering motion state remains. Other than that, it looks good.

[jojojames]

Thanks, changed @noctuid .

[noctuid]

Since initial state changes and evil-make-overriding-map calls are also being moved (which I agree with) in addition to keybindings, you should probably explicitly document that as well.

[jojojames]

Good idea, where to document this?

[noctuid]

I'd mention what is expected to be included in the file in both evil-integration and evil-keybindings (in a commentary section), so that it's hopefully clear for anyone who wants to add something to those files (assuming they read the commentary). I'd also probably mention it in the docstring for evil-want-keybindings (though with a more high level description that doesn't mention the actual evil function/variables; for example, say that functionality in evil-keybindings may remove (mainly) insertion keybindings by changing the initial state and may have some mode's keybindings override evil's defaults).

[noctuid]

I also think that it might be better to rename the file (and maybe the variable; e.g. add -integration or something) because if I didn't already know the difference, I might be confused about evil-keybindings.el vs. evil-maps.el.

[jojojames]

I'll add something for the commentary section but my documentation skills aren't too good. :)

I also think that might be better to rename the file (and maybe the variable; e.g. add -integration or something) because if I didn't already know the difference, I might be confused about evil-keybindings.el vs. evil-maps.el.

I like the shortness of the current file/variable. evil-keybinding-integration and evil-want-keybinding-integration is a mouthful! Hopefully the commentary would be revealing enough? Not a strong opinion though.

[jojojames]

Added some commentary, open to more polish, of course.

[TheBB]

Thanks! I made some minor changes to the comments and merged manually.

[jojojames]

Awesome, thanks @TheBB