🎉 feat: compile thing

Author: SaltyAom

CHANGELOG.md

@@ -3,6 +3,7 @@ Improvement:
 - ValidationError: add `messageValue` as an alias of `errorValue`
 - ValidationError.detail now accept optional 2nd parameter `allowUnsafeValidatorDetails`
 - macro: add `introspect`
+- prevent redundant route compilation
 
 Bug fix:
 - [#1537](https://github.com/elysiajs/elysia/issues/1537) websocket: ping/pong not being called

example/a.ts

@@ -1,31 +1,19 @@
-import { Elysia } from '../src'
+import { InternalSymbolName } from 'typescript'
+import { Elysia, t } from '../src'
 import { req } from '../test/utils'
 
-const app = new Elysia()
-	.macro('a', {
-		introspect(option) {
-			console.log('a', option)
-		},
-		beforeHandle() {
-			console.log('before handle a')
-		}
-	})
-	.macro({
-		b: {
-			introspect(option) {
-				console.log('b', option)
-			},
-			beforeHandle() {
-				console.log('before handle a')
-			}
-		}
-	})
-	.get('/', () => 'hello world', {
-		a: true,
-		b: true,
-		detail: {
-			description: 'a'
-		}
-	})
+const app = new Elysia().get('/', () => 'ok').compile()
+for (const route of app.routes) route.compile()
 
-app.handle(req('/'))
+console.log(app.fetch.toString())
+console.log(app.routes[0].compile().toString())
+
+// Bun.sleepSync(7)
+// console.log('Slept')
+
+const res = app
+	.handle(req('/'))
+	.then((x) => x.text())
+	.then(console.log)
+
+// process.exit(0)

src/adapter/web-standard/index.ts

@@ -93,10 +93,8 @@ export const WebStandardAdapter: ElysiaAdapter = {
 			fnLiteral +=
 				`const u=r.url,` +
 				`s=u.indexOf('/',${standardHostname ? 11 : 7}),` +
-				`qi=u.indexOf('?',s+1)\n` +
-				`let p\n` +
-				`if(qi===-1)p=u.substring(s)\n` +
-				`else p=u.substring(s, qi)\n`
+				`qi=u.indexOf('?',s+1),` +
+				`p=u.substring(s,qi===-1?undefined:qi)\n`
 
 			if (hasTrace) fnLiteral += `const id=randomId()\n`
 

src/index.ts

@@ -909,11 +909,8 @@ export default class Elysia<
 
 		addResponsePath(path)
 
-		let _compiled: ComposedHandler
 		const compile = () => {
-			if (_compiled) return _compiled
-
-			return (_compiled = composeHandler({
+			const compiled = composeHandler({
 				app: this,
 				path,
 				method,
@@ -926,7 +923,12 @@ export default class Elysia<
 						: handle,
 				allowMeta,
 				inference: this.inference
-			}))
+			})
+
+			if (this.router.history[index])
+				this.router.history[index].composed = compiled
+
+			return compiled
 		}
 
 		let oldIndex: number | undefined
@@ -941,22 +943,22 @@ export default class Elysia<
 		else this.routeTree[`${method}_${path}`] = this.router.history.length
 
 		const index = oldIndex ?? this.router.history.length
+		const route = this.router.history
 
 		const mainHandler = shouldPrecompile
 			? compile()
 			: (ctx: Context) =>
-					(
-						(this.router.history[index].composed =
-							compile!()) as ComposedHandler
-					)(ctx)
+					((route[index].composed = compile!()) as ComposedHandler)(
+						ctx
+					)
 
 		if (oldIndex !== undefined)
 			this.router.history[oldIndex] = Object.assign(
 				{
 					method,
 					path,
 					composed: mainHandler,
-					compile: compile!,
+					compile,
 					handler: handle,
 					hooks
 				},
@@ -976,7 +978,7 @@ export default class Elysia<
 						method,
 						path,
 						composed: mainHandler,
-						compile: compile!,
+						compile,
 						handler: handle,
 						hooks
 					},
@@ -987,7 +989,9 @@ export default class Elysia<
 			)
 
 		const handler = {
-			handler: shouldPrecompile ? mainHandler : undefined,
+			handler: shouldPrecompile
+				? (route[index].composed as ComposedHandler)
+				: undefined,
 			compile() {
 				return (this.handler = compile!())
 			}