move mobile callbacks to the externalSigningProviders

Author: juliancwirko

demo-app/index.html

@@ -192,6 +192,8 @@ <h3>Other demos:</h3>
                 walletConnectV2ProjectId: 'f502675c63610bfe4454080ac86d70e6',
                 walletConnectV2RelayAddresses: ['wss://relay.walletconnect.com'],
                 qrCodeContainer: 'qr-code-container',
+                onQrPending: () => { uiPending(true); },
+                onQrLoaded: () => { uiPending(false); },
               }
             }
           },
@@ -210,9 +212,6 @@ <h3>Other demos:</h3>
           onTxSent: (txOnNetwork) => { const hash = txOnNetwork.txHash; hash && updateTxHashContainer(hash, true); },
           onTxFinalized: (tx) => { tx?.hash && updateTxHashContainer(tx.hash); uiPending(false); },
           onTxFailure: (tx, error) => { displayError(error); uiPending(false); },
-          // Qr code callbacks:
-          onQrPending: () => { uiPending(true); },
-          onQrLoaded: () => { uiPending(false); },
           // Signing callbacks:
           onSignMsgStart: (message) => { uiPending(true); },
           onSignMsgFinalized: (message, messageSignature) => { messageSignature && updateOperationResultContainer(`➡️ The signature for "${message}" message:\n${messageSignature}`); uiPending(false); },

packages/elven.js/src/initialize-events-store.ts

@@ -37,11 +37,12 @@ export const initializeEventsStore = (initOptions: InitOptions) => {
   }
 
   // Qr code initialization
-  if (initOptions.onQrPending) {
-    EventsStore.set(EventStoreEvents.onQrPending, initOptions.onQrPending);
+  const mobileConfig = initOptions?.externalSigningProviders?.mobile?.config;
+  if (mobileConfig?.onQrPending) {
+    EventsStore.set(EventStoreEvents.onQrPending, mobileConfig.onQrPending);
   }
-  if (initOptions.onQrLoaded) {
-    EventsStore.set(EventStoreEvents.onQrLoaded, initOptions.onQrLoaded);
+  if (mobileConfig?.onQrLoaded) {
+    EventsStore.set(EventStoreEvents.onQrLoaded, mobileConfig.onQrLoaded);
   }
 
   // Transactions initialization

packages/elven.js/src/types.ts

@@ -17,6 +17,8 @@ export interface MobileSigningProviderConfig {
   walletConnectV2ProjectId: string;
   walletConnectV2RelayAddresses: string[];
   qrCodeContainer: string | HTMLElement;
+  onQrPending: () => void;
+  onQrLoaded: () => void;
 }
 
 export interface WalletConnectV2Provider
@@ -74,9 +76,6 @@ export interface InitOptions {
   onLogoutStart?: () => void;
   onLogoutSuccess?: () => void;
   onLogoutFailure?: (error: string) => void;
-  // Qr
-  onQrPending?: () => void;
-  onQrLoaded?: () => void;
   // Transaction
   onTxStart?: (transaction: Transaction) => void;
   onTxSent?: (transaction: Transaction) => void;