Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] About the Elsa.Workflows.Pipelines.ActivityExecution #6095

Open
zfchai opened this issue Nov 4, 2024 · 1 comment
Open

[ENH] About the Elsa.Workflows.Pipelines.ActivityExecution #6095

zfchai opened this issue Nov 4, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@zfchai
Copy link

zfchai commented Nov 4, 2024

Suggest aligning the ActiveExecution programming paradigm with the WorkflowExecution, for example:

  • ActiveExecutionPipeBuilder suggests renaming it to ActiveExecutionPipeBuilder
  • Add the ActiveExecutionMiddleware class with the following code:
namespace Elsa.Workflows.Pipelines.ActivityExecution;

public abstract class ActivityExecutionMiddleware : IActivityExecutionMiddleware
{
    protected ActivityExecutionMiddleware(ActivityMiddlewareDelegate next) => Next = next;
    protected ActivityMiddlewareDelegate Next { get; }
    public abstract ValueTask InvokeAsync(ActivityExecutionContext context);
}
@zfchai zfchai added the enhancement New feature or request label Nov 4, 2024
@sfmskywalker
Copy link
Member

Makes sense. Do you want to submit a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants