You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I expect elm-review's review/src/ReviewConfig.elm to auto format with elm-format on save, and to also highlight errors as usual
Current Behavior
In the output I can see that it finds both my top level elm.json and the review/elm.json, but then filters out the one in review only resulting in one unique workspace because it's in a subfolder. Now in the output when I save my file I can see that it throws an error that it's not part of any workspace, which I guess is because I don't include it in my source-directories. I would still like it to be auto formatted and linted though, but with the closest elm.json to it, in this case the one at review/elm.json
Possible Solution
I'm not sure if the reason for the unique workspaces thing has something to do with dependencies? But otherwise I would think one could just not filter out the sub workspaces as is being done right now and treat them all as unique workspaces. I guess there's a reason why you've done it like that though. In that case maybe one can only filter it out if that sub workspace is included in the parent workspaces source-directories? That would have avoided this being filtered out.
Steps to Reproduce (for bugs)
Should be enough to just do npx elm-review init and then save the file and look at the output of ElmLS
Context
Your Environment
Version used: 2.6.0
Editor used: VSCode
Environment name and version (e.g. node.js 5.4): node 18.5.0
Operating System and version: Ubuntu 20.04 (in a docker container, but the parent is also Ubuntu 20.04)
The text was updated successfully, but these errors were encountered:
Expected Behavior
I expect elm-review's
review/src/ReviewConfig.elm
to auto format withelm-format
on save, and to also highlight errors as usualCurrent Behavior
In the output I can see that it finds both my top level
elm.json
and thereview/elm.json
, but then filters out the one inreview
only resulting in one unique workspace because it's in a subfolder. Now in the output when I save my file I can see that it throws an error that it's not part of any workspace, which I guess is because I don't include it in my source-directories. I would still like it to be auto formatted and linted though, but with the closestelm.json
to it, in this case the one atreview/elm.json
Possible Solution
I'm not sure if the reason for the unique workspaces thing has something to do with dependencies? But otherwise I would think one could just not filter out the sub workspaces as is being done right now and treat them all as unique workspaces. I guess there's a reason why you've done it like that though. In that case maybe one can only filter it out if that sub workspace is included in the parent workspaces
source-directories
? That would have avoided this being filtered out.Steps to Reproduce (for bugs)
npx elm-review init
and then save the file and look at the output of ElmLSContext
Your Environment
The text was updated successfully, but these errors were encountered: