Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path high-lighting to not look like URL #322

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ambroisie
Copy link

My relevant use-case is for Nix paths, which used to be linked to GruvboxOrange, and just look wrong when underlined.

My relevant use-case is for Nix paths, which used to be linked to
`GruvboxOrange`, and just look wrong when underlined.
@ellisonleao
Copy link
Owner

hey @ambroisie that looks like a personal preference to me, can you provide some screenshots so we can understand the change please?

@ambroisie
Copy link
Author

IMO only actual URLs should look like URLs (i.e: be underlined), it is a personal opinion but I'd think it'd be shared by most. Unfortunately few grammars seem to actually use the path type (e.g: I was expecting C includes to do it, but nope): in the languages I use only Nix is affected.

Will provide screenshots when I'm near a computer.

@ambroisie
Copy link
Author

ambroisie commented Mar 27, 2024

Here is a comparison of before/after:
Screenshot 2024-03-27 10 37 25
Screenshot 2024-03-27 10 37 49

EDIT: do note, the GruvboxOrange is what it used to link to (as it was just a special string), before the grammar and colorscheme were updated for the new capture names.

@ambroisie
Copy link
Author

@ellisonleao friendly ping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants