Skip to content

Commit 7916029

Browse files
committed
Revert "[unified_analytics] Send enabled_features as an event parameter rather than a user property (dart-lang#2007)"
This reverts commit 933f5ea.
1 parent 4e98007 commit 7916029

File tree

8 files changed

+274
-366
lines changed

8 files changed

+274
-366
lines changed

pkgs/unified_analytics/CHANGELOG.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
## 7.0.2
2-
- Send `enabled_features` as an event parameter in all events rather than as a user property.
32
- Allow `LogStatsFile` to contain more granular event types (specifically `property_editor` events).
43

54
## 7.0.1

pkgs/unified_analytics/lib/src/analytics.dart

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -339,7 +339,6 @@ class AnalyticsImpl implements Analytics {
339339
final File _clientIdFile;
340340
final UserProperty _userProperty;
341341
final LogHandler _logHandler;
342-
final String? _enabledFeatures;
343342

344343
/// Tells the client if they need to show a message to the
345344
/// user; this will return true if it is the first time the
@@ -407,8 +406,8 @@ class AnalyticsImpl implements Analytics {
407406
truncateStringToLength(io.Platform.operatingSystemVersion, 36),
408407
locale: io.Platform.localeName,
409408
clientIde: clientIde,
409+
enabledFeatures: enabledFeatures,
410410
),
411-
_enabledFeatures = enabledFeatures,
412411
_configHandler = ConfigHandler(
413412
homeDirectory: homeDirectory,
414413
configFile: homeDirectory
@@ -614,7 +613,6 @@ class AnalyticsImpl implements Analytics {
614613
eventName: event.eventName,
615614
eventData: event.eventData,
616615
userProperty: _userProperty,
617-
enabledFeatures: _enabledFeatures,
618616
);
619617

620618
if (_enableAsserts) checkBody(body);
@@ -656,7 +654,6 @@ class AnalyticsImpl implements Analytics {
656654
eventName: collectionEvent.eventName,
657655
eventData: collectionEvent.eventData,
658656
userProperty: _userProperty,
659-
enabledFeatures: _enabledFeatures,
660657
);
661658

662659
_logHandler.save(data: body);
@@ -667,7 +664,6 @@ class AnalyticsImpl implements Analytics {
667664
clientId: clientId,
668665
eventName: collectionEvent.eventName,
669666
eventData: collectionEvent.eventData,
670-
enabledFeatures: _enabledFeatures,
671667
userProperty: _userProperty,
672668
);
673669

@@ -778,7 +774,6 @@ class FakeAnalytics extends AnalyticsImpl {
778774
eventName: event.eventName,
779775
eventData: event.eventData,
780776
userProperty: _userProperty,
781-
enabledFeatures: _enabledFeatures,
782777
);
783778

784779
if (_enableAsserts) checkBody(body);

pkgs/unified_analytics/lib/src/constants.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ const int kMaxLogFileSize = 25 * (1 << 20);
8787
const String kLogFileName = 'dart-flutter-telemetry.log';
8888

8989
/// The current version of the package, should be in line with pubspec version.
90-
const String kPackageVersion = '7.0.2';
90+
const String kPackageVersion = '7.0.1';
9191

9292
/// The minimum length for a session.
9393
const int kSessionDurationMinutes = 30;

0 commit comments

Comments
 (0)