Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add basic pwa #110

Closed
wants to merge 22 commits into from
Closed

feat: add basic pwa #110

wants to merge 22 commits into from

Conversation

userquin
Copy link
Member

@userquin userquin commented Nov 25, 2022

DON'T MERGE YET (I cannot create draft PR)

This PR includes offline support, added fallback page and prerender it, we can change the name later.

The PWA is registered in dev an on locla build, not yet on deployment:

  • the sw in dev will only intercept the fallback
  • on offline, Elk will work but the sw will redirect to fallback (something similar to twitter/mastodon: works with the SPA but if you refresh the dinossaur will appear)
  • the current strategy is prompt for update: we can change it later, I need to review the dialog/toast
  • if we want to cache also avatars for users we'll need to add cors and change all img tag avatars adding crossorigin="anonymous"; this is not about sponsor avatars (antfu, danielroe, patak...) it is about matodon users

closes #101

@netlify
Copy link

netlify bot commented Nov 25, 2022

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit d835a88
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63834cd300591b0008b65823
😎 Deploy Preview https://deploy-preview-110--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sxzz sxzz changed the title feat: add basic pwa WIP feat: add basic pwa Nov 26, 2022
@userquin userquin changed the title WIP feat: add basic pwa feat: [DRAFT] add basic pwa Nov 27, 2022
@patak-dev patak-dev mentioned this pull request Nov 27, 2022
@patak-dev patak-dev changed the title feat: [DRAFT] add basic pwa feat: add basic pwa WIP Nov 27, 2022
@Shinigami92 Shinigami92 added the c: feature Request for new feature label Nov 28, 2022
@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent needs rebase There is a merge conflict labels Nov 28, 2022
@sxzz sxzz marked this pull request as draft December 2, 2022 08:07
@patak-dev patak-dev changed the title feat: add basic pwa WIP feat: add basic pwa Dec 2, 2022
@userquin
Copy link
Member Author

userquin commented Dec 4, 2022

superseded by #337

@danielroe danielroe closed this Dec 4, 2022
@userquin userquin deleted the userquin/feat-add-pwa branch December 4, 2022 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature needs rebase There is a merge conflict p: 1-normal Nothing urgent
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

add PWA and service worker stuff
4 participants