Skip to content

Conversation

@GuyKh
Copy link
Collaborator

@GuyKh GuyKh commented Mar 24, 2021

No description provided.

@GuyKh
Copy link
Collaborator Author

GuyKh commented Mar 25, 2021

Checked and Verified

@eljeffeg
Copy link
Owner

Thank you for this and the Hebrew translation. I'm going to do a little work on the date to make sure it formats properly. It appears the site uses d/m/yyyy, so we'll want to make sure it reads that and not m/d/yyyy. After that, I'll do a version bump and push it out.

@eljeffeg eljeffeg merged commit aab3956 into eljeffeg:master Mar 27, 2021
@eljeffeg
Copy link
Owner

As a side thought, you may want to consider changing the date formatting to something that is not ambiguous. Many genealogical errors have been made by unknowingly transposing the month and day. If you want to use numerical values, a international standard format of yyyy-mm-dd would probably be better, as the US tends to use mm/dd/yyyy and others dd/mm/yyyy. But I'd suggest just spelling out the month either fully or abbreviated, 4 Sep 1943. No ambiguity

@GuyKh GuyKh deleted the gravez.me branch March 27, 2021 22:30
@eljeffeg
Copy link
Owner

Sorry, I thought you were the requester from this post #94 who ran the sites. If you do happen to have any influence on gravez.me, then maybe that will be helpful, otherwise disregard. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants