Skip to content

Add more candidate pair and transport stats #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Add more candidate pair and transport stats #75

merged 1 commit into from
Mar 19, 2025

Conversation

mickel8
Copy link
Member

@mickel8 mickel8 commented Mar 18, 2025

Add more candidate pair and transport stats.

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 74.11765% with 22 lines in your changes missing coverage. Please review.

Project coverage is 83.83%. Comparing base (334ba47) to head (3a784c0).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
lib/ex_ice/priv/ice_agent.ex 69.86% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
- Coverage   84.29%   83.83%   -0.47%     
==========================================
  Files          25       25              
  Lines        1783     1837      +54     
==========================================
+ Hits         1503     1540      +37     
- Misses        280      297      +17     
Files with missing lines Coverage Δ
lib/ex_ice/priv/candidate_pair.ex 50.00% <ø> (ø)
lib/ex_ice/priv/conn_check_handler/controlled.ex 94.11% <100.00%> (+0.24%) ⬆️
lib/ex_ice/priv/conn_check_handler/controlling.ex 87.14% <100.00%> (+0.77%) ⬆️
lib/ex_ice/priv/ice_agent.ex 86.08% <69.86%> (-0.98%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 334ba47...3a784c0. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mickel8 mickel8 force-pushed the cp-stats branch 4 times, most recently from ba3ff86 to ccde919 Compare March 19, 2025 08:36
@mickel8 mickel8 changed the title Add more CandidatePair stats Add more candidate pair and transport stats Mar 19, 2025
@mickel8 mickel8 marked this pull request as ready for review March 19, 2025 08:58
@mickel8 mickel8 merged commit 2c312c6 into master Mar 19, 2025
4 checks passed
@mickel8 mickel8 deleted the cp-stats branch March 19, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant