Keep headers in non-html render

Author: josevalim

lib/plug/debugger.ex

@@ -206,19 +206,20 @@ defmodule Plug.Debugger do
     session = maybe_fetch_session(conn)
     params = maybe_fetch_query_params(conn)
     {title, message} = info(kind, reason)
+    html? = accepts_html?(get_req_header(conn, "accept"))
 
     assigns = [
       conn: conn,
       title: title,
       formatted: Exception.format(kind, reason, stack),
       session: session,
       params: params,
-      frames: frames(:md, stack, opts)
+      full_version: not html?
     ]
 
     markdown = template_markdown(assigns)
 
-    if accepts_html?(get_req_header(conn, "accept")) do
+    if html? do
       conn =
         conn
         |> put_resp_content_type("text/html")

lib/plug/templates/debugger.md.eex

@@ -15,6 +15,10 @@ Exception:
   * URI: <%= url(@conn) %>
   * Query string: <%= @conn.query_string %>
 
-### Session
+<%= if @full_version do %>### Headers
+  <%= for {key, value} <- Enum.sort(@conn.req_headers) do %>
+  * <%= key %>: <%= value %><% end %>
+
+<% end %>### Session
 
     <%= inspect(@session) %>

test/plug/debugger_test.exs

@@ -316,6 +316,10 @@ defmodule Plug.DebuggerTest do
       |> render([], fn -> raise "oops" end)
 
     assert conn.resp_body =~ "Copy markdown"
+
+    # Does not include Headers in markdown though
+    refute conn.resp_body =~ "Code:"
+    refute conn.resp_body =~ "### Headers"
   end
 
   defp stack(stack) do
@@ -395,7 +399,6 @@ defmodule Plug.DebuggerTest do
       end)
 
     assert get_resp_header(conn, "content-type") == ["text/markdown; charset=utf-8"]
-
     assert get_resp_header(conn, "content-security-policy") == ["abcdef"]
 
     assert conn.resp_body =~ "# Plug.Parsers.UnsupportedMediaTypeError at GET /"