[fix] finding the correct URL of the current target #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Feb 18, 2023
|
No problem! |
|
Thanks @josevalim! I tested it with exqlite on CI, https://github.com/cocoa-xu/exqlite/actions/runs/4210623809, and everything works. As for pulling precompiled binaries, it can also find and reuse the correct one on my macOS and Linux (tested locally). 😃 Should be okay to ship a new version! |
|
done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating URLs in
ElixirMake.Artefact.available_target_urls/2, we should return{{target, nif_version}, url}pairs instead of{target, url}.Then we can find the correct URL of the current target with
{current_target, nif_version}as the key.Sorry for the second PR. Once this is merged, I'll test it a little bit, and if everything works, we can ship a new version!