Mention the fixed regression #13176
Merged
Mention the fixed regression #13176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kudos go to @sabiwara, full log/discussion at: bencheeorg/benchee#406 As best as I learned this was introduced in elixir-lang#11420 and fixed in aabe465 It shouldn't affect almost anyone except for scripting usage of elixir and (probably most notably) benchee benchmarks that don't call functions in a module. I think this warrants a Changelog entry. Not sure if [Compiler] is right and my entry is probably way too wordy - happy to adjust it. I'll also write up a notice at benchee and potentially a blog post so that people can know to potentially redo benchmarks they ran on 1.14-1.15 by either wrapping the functions or the `Benchee.run` invocation in modules or running on an unaffected Elixir version.
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Me again, but as always thanks for all your fantastic work! 💚
Kudos go to @sabiwara, full log/discussion at: bencheeorg/benchee#406
As best as I learned this was introduced in #11420 and fixed in aabe465
It shouldn't affect almost anyone except for scripting usage of elixir and (probably most notably) benchee benchmarks that don't call functions in a module.
I think this warrants a Changelog entry. Not sure if [Compiler] is right and my entry is probably way too wordy - happy to adjust it.
I'll also write up a notice at benchee and potentially a blog post so that people can know to potentially redo benchmarks they ran on 1.14-1.15 by either wrapping the functions or the
Benchee.runinvocation in modules or running on an unaffected Elixir version.