Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

search.delete() always fails (even with matches); nested search.lower_quality dictionary #78

Closed
ScrambledRK opened this issue Sep 15, 2023 · 2 comments
Closed

search.delete() always fails (even with matches); nested search.lower_quality dictionary #78

ScrambledRK opened this issue Sep 15, 2023 · 2 comments
Labels
bug : non-critical A bug was found in difPy, but it is not critical to the functioning of the package. status : implemented Feature was implemented in difPy.

Comments

@ScrambledRK
Copy link

ScrambledRK commented Sep 15, 2023 •
edited
Loading

Hello!

I noticed that delete always fails even though stats and result show matching files.
This is because the lower_quality dictionary ends up nested somehow.

The workaround is to correct that nesting before calling delete.

dif = difPy.build(some_directory)
search = difPy.search(dif)

search.lower_quality = search.lower_quality["lower_quality"]  # the workaround

search.delete(silent_del=True)

I hope to find the time to contribute a fix, but maybe its a trivial fix for some of you?
Anyway, thanks for this well written and awesome library!
@elisemercury
Copy link
Owner

Hi @ScrambledRK ,

Thanks a lot for flagging this! Indeed, this should not be the case and will be fixed in the upcoming difPy update.

Thanks again and best,
Elise

@elisemercury elisemercury added bug : critical A bug was found in difPy, and it is critical to the functioning of the package. status : in progress Feature is currently being implemented in difPy. bug : non-critical A bug was found in difPy, but it is not critical to the functioning of the package. status : implemented Feature was implemented in difPy. and removed bug : critical A bug was found in difPy, and it is critical to the functioning of the package. status : in progress Feature is currently being implemented in difPy. labels Sep 26, 2023
@elisemercury
Copy link
Owner

Hi @ScrambledRK,

This issue has been fixed with difPy v4.0.1. Thanks again for flagging this!

Best,
Elise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug : non-critical A bug was found in difPy, but it is not critical to the functioning of the package. status : implemented Feature was implemented in difPy.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ScrambledRK @elisemercury