diff --git a/lib/Conversion/ExportVerilog/ExportVerilog.cpp b/lib/Conversion/ExportVerilog/ExportVerilog.cpp index 724082f0fdec..7cb604e1b057 100644 --- a/lib/Conversion/ExportVerilog/ExportVerilog.cpp +++ b/lib/Conversion/ExportVerilog/ExportVerilog.cpp @@ -798,7 +798,9 @@ static bool isExpressionUnableToInline(Operation *op, // Scan the users of the operation to see if any of them need this to be // emitted out-of-line. - for (auto *user : op->getUsers()) { + for (auto &use : op->getUses()) { + auto *user = use.getOwner(); + // Verilog bit selection is required by the standard to be: // "a vector, packed array, packed structure, parameter or concatenation". // @@ -808,18 +810,38 @@ static bool isExpressionUnableToInline(Operation *op, // To handle these, we push the subexpression into a temporary. if (isa(user)) - if (op->getResult(0) == user->getOperand(0) && // ignore index operands. - !isOkToBitSelectFrom(op->getResult(0))) + if (use.getOperandNumber() == 0 && // ignore index operands. + !isOkToBitSelectFrom(use.get())) return true; - // Always blocks must have a name in their sensitivity list, not an expr. - if (!options.allowExprInEventControl && isa(user)) { - // Anything other than a read of a wire must be out of line. - if (auto read = dyn_cast(op)) - if (read.getInput().getDefiningOp() || - read.getInput().getDefiningOp()) - continue; - return true; + // Handle option disallowing expressions in event control. + if (!options.allowExprInEventControl) { + // Check operations used for event control, anything other than + // a read of a wire must be out of line. + + // Helper to determine if the use will be part of "event control", + // based on what the operation using it is and as which operand. + auto usedInExprControl = [user, &use]() { + // "disable iff" condition must be a name. + if (auto disableOp = dyn_cast(user)) + return disableOp.getCondition() == use.get(); + // LTL Clock up's clock operand must be a name. + if (auto clockOp = dyn_cast(user)) + return clockOp.getClock() == use.get(); + // Always blocks must have a name in their sensitivity list. + // (all operands) + return isa(user); + }; + + if (!usedInExprControl()) + continue; + + // Otherwise, this can only be inlined if is (already) a read of a wire. + auto read = dyn_cast(op); + if (!read) + return true; + if (!isa_and_nonnull(read.getInput().getDefiningOp())) + return true; } } return false; diff --git a/test/Conversion/ExportVerilog/prepare-for-emission.mlir b/test/Conversion/ExportVerilog/prepare-for-emission.mlir index 6f024439254b..17dd7d7aad4a 100644 --- a/test/Conversion/ExportVerilog/prepare-for-emission.mlir +++ b/test/Conversion/ExportVerilog/prepare-for-emission.mlir @@ -146,6 +146,45 @@ module attributes {circt.loweringOptions = "disallowExpressionInliningInPorts"} } } +// ----- + +module attributes {circt.loweringOptions = "disallowExpressionInliningInPorts"} { + // CHECK-LABEL: @DisableIff( + hw.module @DisableIff(in %clk: i1, in %a: i1, in %b: i1) { + %b_xor_b = comb.xor %b, %b : i1 + + // CHECK: %[[XOR:.+]] = comb.xor + // CHECK: %[[WIRE:.+]] = sv.wire + // CHECK: sv.assign %[[WIRE]], %[[XOR]] + // CHECK: %[[READ:.+]] = sv.read_inout %[[WIRE]] + // CHECK: ltl.disable %{{.+}} if %[[READ]] + %i0 = ltl.implication %a, %b : i1, i1 + %k0 = ltl.clock %i0, posedge %clk : !ltl.property + %k5 = ltl.disable %k0 if %b_xor_b : !ltl.property + + verif.assert %k5: !ltl.property + } +} + +// ----- + +module attributes {circt.loweringOptions = "disallowExpressionInliningInPorts"} { + // CHECK-LABEL: @ClockExpr( + hw.module @ClockExpr(in %clk: i1, in %a: i1, in %b: i1) { + %clk_xor_b = comb.xor %clk, %b : i1 + + // CHECK: %[[XOR:.+]] = comb.xor + // CHECK: %[[WIRE:.+]] = sv.wire + // CHECK: sv.assign %[[WIRE]], %[[XOR]] + // CHECK: %[[READ:.+]] = sv.read_inout %[[WIRE]] + // CHECK: ltl.clock %{{.+}} posedge %[[READ]] + %i0 = ltl.implication %a, %b : i1, i1 + %k0 = ltl.clock %i0, posedge %clk_xor_b : !ltl.property + + verif.assert %k0: !ltl.property + } +} + // ----- module attributes {circt.loweringOptions = "wireSpillingHeuristic=spillLargeTermsWithNamehints,wireSpillingNamehintTermLimit=3"} {