Skip to content

Pass leave from remote invite rejection down Sliding Sync #18375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

Pass leave from remote invite rejection down Sliding Sync #18375

wants to merge 16 commits into from
+274 −104

Conversation

devonh
Copy link
Member

@devonh devonh commented Apr 29, 2025 •
edited
Loading

Fixes #17753

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

erikjohnston and others added 15 commits March 28, 2025 16:27
@erikjohnston
WIP
340ae9b 
This handles membership changes for users that are not in current state
event delta stream table (e.g. rejecting remote invites).
@devonh
Improve reject invite logic
74cd6d5
@reivilibre
simplify query: left joins with e.event_id = NULL never match
17cdd4f
@reivilibre
optimise query: the unioned subqueries can not overlap and don't need…
5ee188a 
… to be made unique
@reivilibre
add missing user_id filter to first half of the query
de7217f
@reivilibre
don't use is for comparing strings returned from the DB; they may n…
9e41abd 
…ot have the same identity
@reivilibre
TODO: suspicion
af7a4af
@reivilibre
TODO: note what indices we need
fd4a633
@devonh
Revert "add missing user_id filter to first half of the query"
e0aad4b 
This reverts commit de7217f.
@devonh
Reapply "add missing user_id filter to first half of the query"
1519d4f 
This reverts commit e0aad4b.
@devonh
Get tests passing again
7ed2a12
@devonh
Cleanup printing
223c87e
@devonh
More printing cleanup
b8d1b5e
@devonh
Readd union optimization
7640c59
@devonh
Merge branch 'develop' into erikj/ss_reject_invites
9138ee0
@devonh devonh requested a review from a team as a code owner April 29, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Locally-rejected invites don't get passed on to the client over SSS
3 participants
@devonh @erikjohnston @reivilibre